any MDC so we do not have to pass a logger around? #1431

deanbiltup · 2024-08-08T11:03:08Z

Is there any request context? In java, it was ThreadLocal until async programming...then Twitter invented Context.scala and Promise.scala so MDC in logback could be swapped.

Best with example.

Filter has MDC.put("requestId", generateUniqueReqId());

in the plain old typescript code without passing loggers around all the place(bad smell if we have to pass our logger all around) ->

class SomeBizClass {
    private _logger = createLogger();
    public someMethod(request: FetchPhotosRequest): FetchPhotosResponse {
            _logger.info("My log here"");
           return ...
    }
}

In this case, the output is msg="My log here" requestId="xxxsomeReqIdxxx"

Is this possible? This was an amazing thing about logback and log4j so in GCP, AWS, you simply filtered on requestId and developers never had to remember to

pass a logger around
type in requestId in every single log statement(nor pass requestId around).

It made things 1. extremely efficient and 2. error-prone. (no one every made any errors forgetting to pass a logger or requestID to log it).

The text was updated successfully, but these errors were encountered:

nomiddlename · 2024-08-08T12:45:19Z

You don’t need to pass loggers around, when you call log4js.getLogger(“some category”) you’ll get a logger with the same context as any other call with the same category. Logger has a method called addContext which lets you store key value pairs, and the pattern layout lets you output those values in your logs. Should do what you want, give it a try.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

any MDC so we do not have to pass a logger around? #1431

any MDC so we do not have to pass a logger around? #1431

any MDC so we do not have to pass a logger around? #1431

any MDC so we do not have to pass a logger around? #1431

Comments