8000 lodash/fp in browser does not handle lodash having been called with `noConflict` · Issue #2694 · lodash/lodash · GitHub
[go: up one dir, main page]
Skip to content

lodash/fp in browser does not handle lodash having been called with noConflict #2694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
daedalus28 opened this issue Sep 30, 2016 · 4 comments
Closed

lodash/fp in browser does not handle lodash having been called with noConflict #2694

daedalus28 opened this issue Sep 30, 2016 · 4 comments
Labels
bug

Comments

@daedalus28
Copy link
Contributor

These lines check if _ is a function, but should really check if it is actually a lodash instance:
https://github.com/lodash/lodash/blob/master/fp/_convertBrowser.js#L15-L17

In our case we still (unfortunately) have some legacy code that needs underscore - we call lodash with noConflict but some code requires underscore to be global. We're working to rip it out completely, but ideally the check here would either be stricter or support some way of opting out of the automatic check (even if it's wrapped in an if (!window.dontAutoFP) or something that we can set before the script loads)
@jdalton jdalton added the bug label Sep 30, 2016
@jdalton
Copy link
Member
jdalton commented Sep 30, 2016

Thanks for the heads up!

@daedalus28
Copy link
Contributor Author

You replied and fixed it within 12 minutes - awesome! Any idea when the next release with this will be? It's affecting some stuff we have in production.

@jdalton
Copy link
Member
jdalton commented Sep 30, 2016

Probably Sunday.

@lock
Copy link
lock bot commented Jan 18, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdalton @daedalus28
0