8000 Cleanup unit tests and update ticket reference in README.md. · lodash/lodash@c7f290f · GitHub
[go: up one dir, main page]

Skip to content

Commit c7f290f

Browse files
committed
Cleanup unit tests and update ticket reference in README.md.
Former-commit-id: c2433e841c20eb17334d375deabcf0605ed49a3b
1 parent bb553b8 commit c7f290f

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,10 +182,10 @@ require({
182182
* `_.clone` should allow `deep` cloning [[#595](https://github.com/documentcloud/underscore/pull/595), [test](https://github.com/bestiejs/lodash/blob/v0.5.2/test/test.js#L205-220)]
183183
* `_.contains` should work with strings [[#667](https://github.com/documentcloud/underscore/pull/667), [test](https://github.com/bestiejs/lodash/blob/v0.5.2/test/test.js#L275-284)]
184184
* `_.escape` should return an empty string when passed `null` or `undefined` [[#427](https://github.com/documentcloud/underscore/issues/427), [test](https://github.com/bestiejs/lodash/blob/v0.5.2/test/test.js#L375-378)]
185-
* `_.extend` should recursively extend objects [[#379](https://github.com/documentcloud/underscore/pull/379), [test](https://github.com/bestiejs/lodash/blob/v0.5.2/test/test.js#L952-974)]
185+
* `_.extend` should recursively extend objects [[#379](https://github.com/documentcloud/underscore/pull/379), [#718](https://github.com/documentcloud/underscore/issues/718), [test](https://github.com/bestiejs/lodash/blob/v0.5.2/test/test.js#L952-974)]
186186
* `_.forEach` should be chainable [[#142](https://github.com/documentcloud/underscore/issues/142), [test](https://github.com/bestiejs/lodash/blob/v0.5.2/test/test.js#L494-497)]
187187
* `_.forEach` should allow exiting iteration early [[#211](https://github.com/documentcloud/underscore/issues/211), [test](https://github.com/bestiejs/lodash/blob/v0.5.2/test/test.js#L589-608)]
188-
* `_.groupBy` should add values to own, not inherited, properties [[test](https://github.com/bestiejs/lodash/blob/v0.5.2/test/test.js#L623-630)]
188+
* `_.countBy` and `_.groupBy` should only add values to own, not inherited, properties [[test](https://github.com/bestiejs/lodash/blob/v0.5.2/test/test.js#L623-630)]
189189
* `_.isElement` should use strict equality for its duck type check [[test](https://github.com/bestiejs/lodash/blob/v0.5.2/test/test.js#L704-713)]
190190
* `_.isEmpty` and `_.size` should support jQuery/MooTools DOM query collections [[#690](https://github.com/documentcloud/underscore/pull/690), [test](https://github.com/bestiejs/lodash/blob/v0.5.2/test/test.js#L740-745)]
191191
* `_.isEqual` should return `true` for like-objects from different documents [[test](https://github.com/bestiejs/lodash/blob/v0.5.2/test/test.js#L781-801)]

test/test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -289,13 +289,13 @@
289289
QUnit.module('lodash.countBy');
290290

291291
(function() {
292-
test('should only add elements to own, not inherited, properties', function() {
292+
test('should only add values to own, not inherited, properties', function() {
293293
var actual = _.countBy([4.2, 6.1, 6.4], function(num) {
294294
return Math.floor(num) > 4 ? 'hasOwnProperty' : 'constructor';
295295
});
296296

297-
deepEqual(actual.constructor, 1);
298-
deepEqual(actual.hasOwnProperty, 2);
297+
equal(actual.constructor, 1);
298+
equal(actual.hasOwnProperty, 2);
299299
});
300300
}());
301301

@@ -620,7 +620,7 @@
620620
deepEqual(actual, { '4': [4.2], '6': [6.1, 6.4] });
621621
});
622622

623-
test('should only add elements to own, not inherited, properties', function() {
623+
test('should only add values to own, not inherited, properties', function() {
624624
var actual = _.groupBy([4.2, 6.1, 6.4], function(num) {
625625
return Math.floor(num) > 4 ? 'hasOwnProperty' : 'constructor';
626626
});

0 commit comments

Comments
 (0)
0