8000 Rename `_.random` params `start` and `end` to `lower` and `upper`. · lodash/lodash@5a13fe2 · GitHub
[go: up one dir, main page]

Skip to content

Commit 5a13fe2

Browse files
committed
Rename _.random params start and end to lower and upper.
1 parent 946560c commit 5a13fe2

File tree

1 file changed

+34
-34
lines changed

1 file changed

+34
-34
lines changed

lodash.js

Lines changed: 34 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -3202,12 +3202,12 @@
32023202
* floating-point numbers.
32033203
*
32043204
* @private
3205-
* @param {number} min The minimum possible value.
3206-
* @param {number} max The maximum possible value.
3205+
* @param {number} lower The lower bound.
3206+
* @param {number} upper The upper bound.
32073207
* @returns {number} Returns the random number.
32083208
*/
3209-
function baseRandom(min, max) {
3210-
return min + nativeFloor(nativeRandom() * (max - min + 1));
3209+
function baseRandom(lower, upper) {
3210+
return lower + nativeFloor(nativeRandom() * (upper - lower + 1));
32113211
}
32123212

32133213
/**
@@ -11654,19 +11654,19 @@
1165411654
}
1165511655

1165611656
/**
11657-
* Produces a random number between `min` and `max` (inclusive). If only one
11658-
* argument is provided a number between `0` and the given number is returned.
11659-
* If `floating` is `true`, or either `min` or `max` are floats, a
11660-
* floating-point number is returned instead of an integer.
11657+
* Produces a random number between the inclusive `lower` and `upper` bounds.
11658+
* If only one argument is provided a number between `0` and the given number
11659+
* is returned. If `floating` is `true`, or either `lower` or `upper` are floats,
11660+
* a floating-point number is returned instead of an integer.
1166111661
*
1166211662
* **Note:** JavaScript follows the IEEE-754 standard for resolving
1166311663
* floating-point values which can produce unexpected results.
1166411664
*
1166511665
* @static
1166611666
* @memberOf _
1166711667
* @category Number
11668-
* @param {number} [min=0] The minimum possible value.
11669-
* @param {number} [max=1] The maximum possible value.
11668+
* @param {number} [lower=0] The lower bound.
11669+
* @param {number} [upper=1] The upper bound.
1167011670
* @param {boolean} [floating] Specify returning a floating-point number.
1167111671
* @returns {number} Returns the random number.
1167211672
* @example
@@ -11683,43 +11683,43 @@
1168311683
* _.random(1.2, 5.2);
1168411684
* // => a floating-point number between 1.2 and 5.2
1168511685
*/
11686-
function random(min, max, floating) {
11687-
if (floating && typeof floating != 'boolean' && isIterateeCall(min, max, floating)) {
11688-
max = floating = undefined;
11686+
function random(lower, upper, floating) {
11687+
if (floating && typeof floating != 'boolean' && isIterateeCall(lower, upper, floating)) {
11688+
upper = floating = undefined;
1168911689
}
1169011690
if (floating === undefined) {
11691-
if (typeof max == 'boolean') {
11692-
floating = max;
11693-
max = undefined;
11691+
if (typeof upper == 'boolean') {
11692+
floating = upper;
11693+
upper = undefined;
1169411694
}
11695-
else if (typeof min == 'boolean') {
11696-
floating = min;
11697-
min = undefined;
11695+
else if (typeof lower == 'boolean') {
11696+
floating = lower;
11697+
lower = undefined;
1169811698
}
1169911699
}
11700-
if (min === undefined && max === undefined) {
11701-
min = 0;
11702-
max = 1;
11700+
if (lower === undefined && upper === undefined) {
11701+
lower = 0;
11702+
upper = 1;
1170311703
}
1170411704
else {
11705-
min = toNumber(min) || 0;
11706-
if (max === undefined) {
11707-
max = min;
11708-
min = 0;
11705+
lower = toNumber(lower) || 0;
11706+
if (upper === undefined) {
11707+
upper = lower;
11708+
lower = 0;
1170911709
} else {
11710-
max = toNumber(max) || 0;
11710+
upper = toNumber(upper) || 0;
1171111711
}
1171211712
}
11713-
if (min > max) {
11714-
var temp = min;
11715-
min = max;
11716-
max = temp;
11713+
if (lower > upper) {
11714+
var temp = lower;
11715+
lower = upper;
11716+
upper = temp;
1171711717
}
11718-
if (floating || 6D4E min % 1 || max % 1) {
11718+
if (floating || lower % 1 || upper % 1) {
1171911719
var rand = nativeRandom();
11720-
return nativeMin(min + (rand * (max - min + freeParseFloat('1e-' + ((rand + '').length - 1)))), max);
11720+
return nativeMin(lower + (rand * (upper - lower + freeParseFloat('1e-' + ((rand + '').length - 1)))), upper);
1172111721
}
11722-
return baseRandom(min, max);
11722+
return baseRandom(lower, upper);
1172311723
}
1172411724

1172511725
/*------------------------------------------------------------------------*/

0 commit comments

Comments
 (0)
0