Ensure _.xor returns an empty array when comparing the same array. [closes #2776]

jdalton · jdalton · commit 0fcf43b02b37 · 2016-10-31T16:32:58.000-07:00
diff --git a/lodash.js b/lodash.js
@@ -4414,7 +4414,7 @@
 
         while (++othIndex < length) {
           var othArray = arrays[othIndex];
-          if (othArray !== array) {
+          if (othIndex != index) {
             result[index] = baseDifference(result[index] || array, othArray, iteratee, comparator);
           }
         }
diff --git a/test/test.js b/test/test.js
@@ -25279,6 +25279,15 @@
       assert.deepEqual(actual, []);
     });
 
+    QUnit.test('`_.' + methodName + '` should return an empty array when comparing the same array', function(assert) {
+      assert.expect(1);
+
+      var array = [1],
+          actual = func(array, array, array);
+
+      assert.deepEqual(actual, []);
+    });
+
     QUnit.test('`_.' + methodName + '` should return an array of unique values', function(assert) {
       assert.expect(2);
 

Original file line number	Diff line number	Diff line change
`@@ -4414,7 +4414,7 @@`
`4414`	`4414`
`4415`	`4415`	`while (++othIndex < length) {`
`4416`	`4416`	`var othArray = arrays[othIndex];`
`4417`		`- if (othArray !== array) {`
	`4417`	`+ if (othIndex != index) {`
`4418`	`4418`	`result[index] = baseDifference(result[index] \|\| array, othArray, iteratee, comparator);`
`4419`	`4419`	`}`
`4420`	`4420`	`}`