Ensure _.bind correctly appends array arguments to partially applied arguments.

jdalton · jdalton · commit 04425786a124 · 2012-08-18T02:11:40.000-07:00
Former-commit-id: 4fdb100f83ff9a0eafcba3f5bf91872748205595
diff --git a/lodash.js b/lodash.js
@@ -3224,7 +3224,7 @@
       }
       if (partialArgs.length) {
         args = args.length
-          ? concat.apply(partialArgs, args)
+          ? partialArgs.concat(slice.call(args))
           : partialArgs;
       }
       if (this instanceof bound) {
diff --git a/test/test.js b/test/test.js
@@ -143,6 +143,14 @@
   QUnit.module('lodash.bind');
 
   (function() {
+    test('should correctly append array arguments to partially applied arguments (test in IE < 9)', function() {
+      var args,
+          bound = _.bind(function() { args = slice.call(arguments); }, null, 'a');
+
+      bound(['b'], 'c');
+      deepEqual(args, ['a', ['b'], 'c']);
+    });
+
     test('supports lazy bind', function() {
       var object = {
         'name': 'moe',

Original file line number	Diff line number	Diff line change
`@@ -3224,7 +3224,7 @@`
`3224`	`3224`	`}`
`3225`	`3225`	`if (partialArgs.length) {`
`3226`	`3226`	`args = args.length`
`3227`		`- ? concat.apply(partialArgs, args)`
	`3227`	`+ ? partialArgs.concat(slice.call(args))`
`3228`	`3228`	`: partialArgs;`
`3229`	`3229`	`}`
`3230`	`3230`	`if (this instanceof bound) {`