8000 Why replace "localhost" for S3 endpoints only? · Issue #110 · localstack/localstack-java-utils · GitHub
[go: up one dir, main page]

Skip to content
Why replace "localhost" for S3 endpoints only? #110
Open
@ErwanGSG

Description

@ErwanGSG

When fetching the endpoints for S3, additional logic replaces localhost with s3.localhost.localstack.cloud.

    public String getEndpointS3() {
        String s3Endpoint = endpointForService(ServiceName.S3);
        s3Endpoint = s3Endpoint.replace("localhost", Constants.S3_LOCALHOST_DOMAIN_NAME);
        return s3Endpoint;
    }

s3Endpoint = s3Endpoint.replace("localhost", Constants.S3_LOCALHOST_DOMAIN_NAME);

I would like to configure all endpoints to be based on localhost.localstack.cloud. On local machines, this resolves to localhost, and on my CI I can add an entry to the machine's /etc/hosts file to point to my docker service container running elsewhere on the network.

Problem, when my global endpoint is already localhost.localstack.cloud, this results in s3.localhost.localstack.cloud.localstack.cloud, which is obviously wrong.

Why have separate logic only for the S3 services?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0