8000 Update lambda java lib to 0.2.22 by dfangl · Pull Request #7373 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

Update lambda java lib to 0.2.22 #7373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2022
Merged

Update lambda java lib to 0.2.22 #7373

merged 1 commit into from
Dec 20, 2022

Conversation

dfangl
Copy link
Member
@dfangl dfangl commented Dec 20, 2022 •
edited
Loading

Problem

With #6603 we removed the "sqs": True part of sqs payloads.
While this is correct in terms of parity, this broke the lambda-java-utils (https://github.com/localstack/localstack-java-utils) library we use for local lambda execution, which depended on that attribute.

Solution

  • The new version of localstack-java-utils uses an attribute which is supposed to be in the payload to determine SQS events, which fixes the execution of these handlers in LocalStack.

It is not a good fix, since we should not rely on the data layout for this, but it fixes the regression.

Fixes #6995

Relevant localstack-java-utils PR: localstack/localstack-java-utils#98

@dfangl dfangl temporarily deployed to localstack-ext-tests December 20, 2022 19:24 — with GitHub Actions Inactive
dominikschubert
dominikschubert approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member
@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@github-actions
Copy link

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 23m 47s ⏱️ +12s
1 574 tests ±0  1 301 ✔️ ±0  273 💤 ±0  0 ❌ ±0 
2 218 runs  ±0  1 669 ✔️ ±0  549 💤 ±0  0 ❌ ±0 

Results for commit a7ca809. ± Comparison against base commit 048dae0.

@dfangl dfangl merged commit 6614449 into master Dec 20, 2022
@dfangl dfangl deleted the update-lambda-java-lib branch December 20, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: java.lang.IllegalArgumentException: argument type mismatch with RequestHandler
2 participants
@dfangl @dominikschubert
0