8000 Fix Workflow summaries for ARM workflows by silv-io · Pull Request #12707 · localstack/localstack · GitHub

Fix Workflow summaries for ARM workflows #12707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

silv-io merged 1 commit into master from fix-arm-workflow-summaries

Jun 5, 2025

Member

silv-io commented

•

Motivation

While looking at a failed ARM workflow run, I've noticed that arm64 workflow summaries don't work. The reason is a wrong determination of the architecture that is to be reported.
For simplicity, the matrix for determining the architecture remained the same between workflow run and publishing. The error happened in choosing only AMD to actually run the publishing job. To determine the architecture that should be published, however, we checked the architecture of the runner - which would only be AMD.

Because amd64 and arm64 look so similar we didn't spot this in the initial PR.

To fix this, we can simplify the matrix a bit and just iterate over the actual values amd64 and arm64.

Changes

change matrix to iterate over amd64 and arm64 and use the matrix value directly for downloading and publishing the summary.

Testing

Run the ARM tests manually and look in the PR summaries for the ARM test results
- https://github.com/localstack/localstack/actions/runs/15466016690
- See below, arm results are showing ✅

silv-io requested a review from k-a-il

June 4, 2025 06:55

silv-io added the semver: patch label

silv-io added this to the 4.5 milestone

github-actions bot commented

•

Test Results - Preflight, Unit

21 595 tests 19 940 ✅ 6m 13s ⏱️
1 suites 1 655 💤
1 files 0 ❌

Results for commit 1615279.

♻️ This comment has been updated with latest results.

github-actions bot commented

•

Test Results (MA/MR) - Preflight, Unit

21 595 tests 19 940 ✅ 6m 30s ⏱️
1 suites 1 655 💤
1 files 0 ❌

Results for commit 1615279.

♻️ This comment has been updated with latest results.

github-actions bot commented

•

Test Results (amd64, MA/MR) - Acceptance

7 tests 5 ✅ 3m 8s ⏱️
1 suites 2 💤
1 files 0 ❌

Results for commit 1615279.

♻️ This comment has been updated with latest results.

github-actions bot commented

•

Test Results (amd64) - Acceptance

7 tests 5 ✅ 3m 7s ⏱️
1 suites 2 💤
1 files 0 ❌

Results for commit 1615279.

♻️ This comment has been updated with latest results.

github-actions bot commented

•

Test Results (MA/MR) - Alternative Providers

986 tests 568 ✅ 22m 43s ⏱️
4 suites 418 💤
4 files 0 ❌

Results for commit 1615279.

♻️ This comment has been updated with latest results.

github-actions bot commented

•

Test Results - Alternative Providers

986 tests 568 ✅ 22m 44s ⏱️
4 suites 418 💤
4 files 0 ❌

Results for commit 1615279.

♻️ This comment has been updated with latest results.

github-actions bot commented

•

Test Results (amd64, MA/MR) - Integration, Bootstrap

5 files 5 suites 2h 21m 38s ⏱️
5 227 tests 4 298 ✅ 929 💤 0 ❌
5 233 runs 4 298 ✅ 935 💤 0 ❌

Results for commit 1615279.

♻️ This comment has been updated with latest results.

github-actions bot commented

•

Test Results (amd64) - Integration, Bootstrap

5 files 5 suites 2h 22m 8s ⏱️
5 227 tests 4 298 ✅ 929 💤 0 ❌
5 233 runs 4 298 ✅ 935 💤 0 ❌

Results for commit 1615279.

♻️ This comment has been updated with latest results.

silv-io mentioned this pull request

Add missing switch for forcing ARM tests on workflow dispatch #12709

Merged

2 tasks

silv-io force-pushed the fix-arm-workflow-summaries branch from e64b5da to 4b413b7 Compare

June 4, 2025 12:17

tiurin modified the milestones: 4.5, Playground

silv-io force-pushed the fix-arm-workflow-summaries branch from 4b413b7 to bed4e6f Compare

June 4, 2025 15:46


          Fix Workflow summaries for ARM workflows

silv-io force-pushed the fix-arm-workflow-summaries branch from bed4e6f to 1615279 Compare

June 5, 2025 11:36

github-actions bot commented

Test Results (arm64) - Acceptance

7 tests 5 ✅ 3m 18s ⏱️
1 suites 2 💤
1 files 0 ❌

Results for commit 1615279.

silv-io marked this pull request as ready for review

June 5, 2025 12:06

silv-io requested review from alexrashed, dfangl and dominikschubert as code owners

June 5, 2025 12:06

k-a-il approved these changes

View reviewed changes

Contributor

k-a-il left a comment

LGTM 🚀

silv-io merged commit 94db52d into master

98 checks passed

silv-io deleted the fix-arm-workflow-summaries branch

June 5, 2025 13:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

k-a-il k-a-il approved these changes

alexrashed Awaiting requested review from alexrashed alexrashed is a code owner

dfangl Awaiting requested review from dfangl dfangl is a code owner

dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

Labels

0