-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
ffmpeg: Update build source to use BtbN GitHub Releases #12634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I hope this source proves to be more reliable 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for jumping on this!
I was wondering about the retention policy:
The last build of each month is kept for two years.
The last 14 daily builds are kept.
Have you verified that if there is a new ffmpeg release (7.2), would our pinning of 7.1 and use of latest
marker in the URL not cause the link to break? Would it continue to point to the 'last build of the month' for as long as the build is stored?
The link will break beyond two years, I'm guessing that's acceptable lifetime of a LS release anyway.
I would also like @alexrashed to take a look at this.
Great points! Regarding your concern: It would not break immediately. The URL targets a 7.1-specific build, which will continue to receive nightly rebuilds until 7.2 becomes the new upstream release. Once 7.2 is out, n7.1-latest would no longer be updated, but the last 7.1 monthly build would remain available for 2 years, but will not be referenced by latest anymore in such cases. After that, we would need to either: Refresh the pinned version (e.g., to 7.2) or follow the approach already described in Notion concerning the mirror the binary internally (e.g., to S3 or artifacts) if long-term retention is required. I already synced with @alexrashed about the current approach in Notion, but I’m happy to wait for his review, though that likely means a ~3-week timeline since he’s on vacation 😛 Let me know how you'd like to proceed! 🙂 |
Marking this PR as a draft to prevent any accidental merges until we reach a conclusion on this. |
Understood, thanks for clarifying 👍 Good job with actively starting the discussion and passing this through others. I think we can proceed with the merge. |
Motivation
The current
ffmpeg
installer in LocalStack downloads binaries from johnvansickle.com, a privately hosted site that has exhibited timeout issues, likely due to bandwidth limitations or rate throttling.To address this, we are switching to BtbN/FFmpeg-Builds — a well-maintained, GitHub-hosted source for
ffmpeg
binaries with:Changes
ffmpeg
download URL with BtbN-hosted static LGPL7.1
builds.bin/ffmpeg
,bin/ffprobe
)Testing
Successful installation tested in local setup-

Successful installation tested in CI-
https://app.circleci.com/pipelines/github/localstack/localstack/32720/workflows/4f5455cf-dddb-4d27-b11b-75c52c3c604a