fix APIGW AWS_PROXY lambda response validation #11856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalStack Community integration with Pro 2 files ± 0 2 suites ±0 25m 40s ⏱️ - 1h 17m 54s Results for commit f346239. ± Comparison against base commit 385a141. This pull request removes 2718 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
f8a00e4 to
f346239
Compare
8000
cloutierMat
approved these changes
Nov 15, 2024
Comment on lines
+1060
to
+1068
| response = _invoke( | ||
| body={ | ||
| "statusCode": 200, | ||
| "multiValueHeaders": {"tesT-Multi": ["value-multi"]}, | ||
| "headers": {"test-multi": "value-solo"}, | ||
| }, | ||
| return_headers=True, | ||
| ) | ||
| snapshot.match("invoke-api-multi-headers-overwrite-casing", response) |
There was a problem hiding this comment.
That is an interesting case!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We got a report in our Community Slack regarding too strict lambda payload response validation for the
AWS_PROXYintegration:It seems we were too strict, and didn't have this validated by tests. I've added a quite complete tests inspired by some of our other work.
I've also spotted an issue in our multi value headers handling which I've sneaked a fix for.
Changes
headerswas set tonull