From e5ac579f073ebcd9494838f19926869abd637f1a Mon Sep 17 00:00:00 2001 From: Nevil Macwan Date: Wed, 16 Oct 2024 20:08:10 +0530 Subject: [PATCH 1/2] fixed s3 deletion from stack in cdk --- localstack-core/localstack/testing/scenario/provisioning.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/localstack-core/localstack/testing/scenario/provisioning.py b/localstack-core/localstack/testing/scenario/provisioning.py index 1d127220ef472..0f269f1ce0b5c 100644 --- a/localstack-core/localstack/testing/scenario/provisioning.py +++ b/localstack-core/localstack/testing/scenario/provisioning.py @@ -243,9 +243,10 @@ def provision(self, skip_deployment: Optional[bool] = False): ] for s3_bucket in s3_buckets: + bucket_to_delete = s3_bucket # Capture current value self.custom_cleanup_steps.append( - lambda: cleanup_s3_bucket( - self.aws_client.s3, s3_bucket, delete_bucket=False + lambda bucket=bucket_to_delete: cleanup_s3_bucket( + self.aws_client.s3, bucket, delete_bucket=False ) ) From 1b8f9b7fa76263b7bc0e1c33db08d135136b5e06 Mon Sep 17 00:00:00 2001 From: Nevil Macwan Date: Mon, 21 Oct 2024 18:50:31 +0530 Subject: [PATCH 2/2] resolved reviews --- localstack-core/localstack/testing/scenario/provisioning.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/localstack-core/localstack/testing/scenario/provisioning.py b/localstack-core/localstack/testing/scenario/provisioning.py index 0f269f1ce0b5c..62c984a821694 100644 --- a/localstack-core/localstack/testing/scenario/provisioning.py +++ b/localstack-core/localstack/testing/scenario/provisioning.py @@ -243,9 +243,8 @@ def provision(self, skip_deployment: Optional[bool] = False): ] for s3_bucket in s3_buckets: - bucket_to_delete = s3_bucket # Capture current value self.custom_cleanup_steps.append( - lambda bucket=bucket_to_delete: cleanup_s3_bucket( + lambda bucket=s3_bucket: cleanup_s3_bucket( self.aws_client.s3, bucket, delete_bucket=False ) )