From a6df13b66965a3bb964b93b9177cf5102f57c84e Mon Sep 17 00:00:00 2001 From: Benjamin Simon Date: Fri, 11 Oct 2024 18:58:17 +0200 Subject: [PATCH 1/2] add DMS ServicePrincipal --- localstack-core/localstack/utils/aws/client_types.py | 1 + 1 file changed, 1 insertion(+) diff --git a/localstack-core/localstack/utils/aws/client_types.py b/localstack-core/localstack/utils/aws/client_types.py index 2da2a7d68714a..89d0bb6cf79b7 100644 --- a/localstack-core/localstack/utils/aws/client_types.py +++ b/localstack-core/localstack/utils/aws/client_types.py @@ -264,6 +264,7 @@ class ServicePrincipal(str): """ apigateway = "apigateway" + dms = "dms" events = "events" firehose = "firehose" lambda_ = "lambda" From a0ca9e4aeda596d1e3b06d5e295f4cb79fc1f647 Mon Sep 17 00:00:00 2001 From: Benjamin Simon Date: Fri, 11 Oct 2024 19:13:36 +0200 Subject: [PATCH 2/2] use StrEnum --- localstack-core/localstack/utils/aws/client_types.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/localstack-core/localstack/utils/aws/client_types.py b/localstack-core/localstack/utils/aws/client_types.py index 89d0bb6cf79b7..146585d300fc3 100644 --- a/localstack-core/localstack/utils/aws/client_types.py +++ b/localstack-core/localstack/utils/aws/client_types.py @@ -1,4 +1,5 @@ import abc +from enum import StrEnum from typing import TYPE_CHECKING, Union """ @@ -249,7 +250,7 @@ class TypedServiceClientFactory(abc.ABC): xray: Union["XRayClient", "MetadataRequestInjector[XRayClient]"] -class ServicePrincipal(str): +class ServicePrincipal(StrEnum): """ Class containing defined service principals. To add to this list, please look up the correct service principal name for the service.