Log exception instead of propagating

viren-nadkarni · viren-nadkarni · commit f12ee638dccd · 2024-07-03T14:42:45.000+05:30
diff --git a/localstack-core/localstack/aws/handlers/openapi.py b/localstack-core/localstack/aws/handlers/openapi.py
@@ -2,15 +2,20 @@
 Handlers for validating request and response schema against OpenAPI specs.
 """
 
+import logging
+
 from openapi_core import OpenAPI
 from openapi_core.contrib.werkzeug import WerkzeugOpenAPIRequest, WerkzeugOpenAPIResponse
+from openapi_core.exceptions import OpenAPIError
 
 from localstack import spec
 from localstack.aws.api import RequestContext
 from localstack.aws.chain import Handler, HandlerChain
 from localstack.constants import INTERNAL_RESOURCE_PATH
 from localstack.http import Response
 
+LOG = logging.getLogger(__name__)
+
 
 class OpenAPIRequestValidator(Handler):
     def __init__(self):
@@ -20,7 +25,11 @@ def __call__(self, chain: HandlerChain, context: RequestContext, response: Respo
         path = context.request.path
 
         if path.startswith(INTERNAL_RESOURCE_PATH) or path.startswith("/_aws/"):
-            self.openapi.validate_request(WerkzeugOpenAPIRequest(context.request))
+            try:
+                self.openapi.validate_request(WerkzeugOpenAPIRequest(context.request))
+            except OpenAPIError as exc:
+                # TODO: propagate the exception?
+                LOG.error(exc)
 
 
 class OpenAPIResponseValidator(OpenAPIRequestValidator):
