8000 Fix naming in Lambda revisions (#7551) · localstack/localstack@e8a7f54 · GitHub
[go: up one dir, main page]

Skip to content

Commit e8a7f54

Browse files
authored
Fix naming in Lambda revisions (#7551)
1 parent 8f77fa8 commit e8a7f54

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

localstack/services/awslambda/provider.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1756,13 +1756,13 @@ def add_permission(
17561756
# TODO: re-evaluate data model to prevent this dirty hack just for bumping the revision id
17571757
# TODO: does that need a `with function.lock` for atomic updates of the policy + revision_id?
17581758
if api_utils.qualifier_is_alias(resolved_qualifier):
1759-
latest_alias = resolved_fn.aliases[resolved_qualifier]
1760-
resolved_fn.aliases[resolved_qualifier] = dataclasses.replace(latest_alias)
1759+
resolved_alias = resolved_fn.aliases[resolved_qualifier]
1760+
resolved_fn.aliases[resolved_qualifier] = dataclasses.replace(resolved_alias)
17611761
# Assumes that a non-alias is a version
17621762
else:
1763-
latest_version = resolved_fn.versions[resolved_qualifier]
1763+
resolved_version = resolved_fn.versions[resolved_qualifier]
17641764
resolved_fn.versions[resolved_qualifier] = dataclasses.replace(
1765-
latest_version, config=dataclasses.replace(latest_version.config)
1765+
resolved_version, config=dataclasses.replace(resolved_version.config)
17661766
)
17671767
return AddPermissionResponse(Statement=json.dumps(permission_statement))
17681768

@@ -1819,13 +1819,13 @@ def remove_permission(
18191819
# TODO: re-evaluate data model to prevent this dirty hack just for bumping the revision id
18201820
# TODO: does that need a `with function.lock` for atomic updates of the policy + revision_id?
18211821
if api_utils.qualifier_is_alias(resolved_qualifier):
1822-
latest_alias = resolved_fn.aliases[resolved_qualifier]
1823-
resolved_fn.aliases[resolved_qualifier] = dataclasses.replace(latest_alias)
1822+
resolved_alias = resolved_fn.aliases[resolved_qualifier]
1823+
resolved_fn.aliases[resolved_qualifier] = dataclasses.replace(resolved_alias)
18241824
# Assumes that a non-alias is a version
18251825
else:
1826-
latest_version = resolved_fn.versions[resolved_qualifier]
1826+
resolved_version = resolved_fn.versions[resolved_qualifier]
18271827
resolved_fn.versions[resolved_qualifier] = dataclasses.replace(
1828-
latest_version, config=dataclasses.replace(latest_version.config)
1828+
resolved_version, config=dataclasses.replace(resolved_version.config)
18291829
)
18301830

18311831
# remove the policy as a whole when there's no statement left in it
@@ -1856,12 +1856,12 @@ def get_policy(
18561856

18571857
fn_revision_id = None
18581858
if api_utils.qualifier_is_alias(resolved_qualifier):
1859-
latest_alias = resolved_fn.aliases[resolved_qualifier]
1860-
fn_revision_id = latest_alias.revision_id
1859+
resolved_alias = resolved_fn.aliases[resolved_qualifier]
1860+
fn_revision_id = resolved_alias.revision_id
18611861
# Assumes that a non-alias is a version
18621862
else:
1863-
latest_version = resolved_fn.versions[resolved_qualifier]
1864-
fn_revision_id = latest_version.config.revision_id
1863+
resolved_version = resolved_fn.versions[resolved_qualifier]
1864+
fn_revision_id = resolved_version.config.revision_id
18651865

18661866
return GetPolicyResponse(
18671867
Policy=json.dumps(dataclasses.asdict(function_permission.policy)),

0 commit comments

Comments
 (0)
0