Idempotent start of the DynamoDB server (#11815)

giograno · web-flow · commit ab64e0f9ddce · 2024-11-11T13:12:03.000+01:00
diff --git a/localstack-core/localstack/services/dynamodb/server.py b/localstack-core/localstack/services/dynamodb/server.py
@@ -76,9 +76,14 @@ def __init__(
     def get() -> "DynamodbServer":
         return DynamodbServer(config.DYNAMODB_LOCAL_PORT)
 
+    @synchronized(lock=RESTART_LOCK)
     def start_dynamodb(self) -> bool:
         """Start the DynamoDB server."""
 
+        # We want this method to be idempotent.
+        if self.is_running() and self.is_up():
+            return True
+
         # For the v2 provider, the DynamodbServer has been made a singleton. Yet, the Server abstraction is modelled
         # after threading.Thread, where Start -> Stop -> Start is not allowed. This flow happens during state resets.
         # The following is a workaround that permits this flow
