Address review comments

simonrw · simonrw · commit aa4269c4e81b · 2024-05-15T16:47:05.000+01:00
diff --git a/localstack/logging/setup.py b/localstack/logging/setup.py
@@ -94,7 +94,7 @@ def setup_logging_from_config():
             raise
         except Exception as e:
             raise RuntimeError(
-                f"Failed to configure logging overrides ({raw_logging_override}): Malformed value. ({e})"
+                f"Failed to configure logging overrides ({raw_logging_override})"
             ) from e
 
 
diff --git a/localstack/utils/collections.py b/localstack/utils/collections.py
@@ -536,9 +536,15 @@ def is_comma_delimited_list(string: str, item_regex: Optional[str] = None) -> bo
 
 
 def parse_key_value_pairs(raw_text: str) -> dict:
+    """
+    Parse a series of key-value pairs, in an environment variable format into a dictionary
+
+    >>> input = "a=b,c=d"
+    >>> assert parse_key_value_pairs(input) == {"a": "b", "c": "d"}
+    """
     result = {}
     for pair in raw_text.split(","):
-        items = pair.split("=", maxsplit=2)
+        items = pair.split("=")
         if len(items) != 2:
             raise ValueError(f"invalid key/value pair: '{pair}'")
         raw_key, raw_value = items[0].strip(), items[1].strip()
