8000 fix status code for CreateApiMapping (#11569) · localstack/localstack@83f7b3c · GitHub
[go: up one dir, main page]

Skip to content

Commit 83f7b3c

Browse files
authored
fix status code for CreateApiMapping (#11569)
1 parent 85050a6 commit 83f7b3c

File tree

3 files changed

+11
-6
lines changed

3 files changed

+11
-6
lines changed

localstack-core/localstack/aws/spec-patches.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1314,6 +1314,11 @@
13141314
"op": "add",
13151315
"path": "/operations/UpdateRoute/http/responseCode",
13161316
"value": 201
1317+
},
1318+
{
1319+
"op": "add",
1320+
"path": "/operations/CreateApiMapping/http/responseCode",
1321+
"value": 200
13171322
}
13181323
]
13191324
}

localstack-core/localstack/config.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ def for_host() -> "Directories":
153153
@staticmethod
154154
def for_cli() -> "Directories":
155155
"""Returns directories used for when running localstack CLI commands from the host system. Unlike
156-
``for_container``, these are meant to be cross-platform. Ideally, this should not be needed at all,
156+
``for_container``, these needs to be cross-platform. Ideally, this should not be needed at all,
157157
because the localstack runtime and CLI do not share any control paths. There are a handful of
158158
situations where directories or files may be created lazily for CLI commands. Some paths are
159159
intentionally set to None to provoke errors if these paths are used from the CLI - which they
@@ -338,7 +338,7 @@ def in_docker():
338338
if os_hostname and os_hostname in content:
339339
return True
340340

341-
# container does not set any specific file or config, but it does use
341+
# containerd does not set any specific file or config, but it does use
342342
# io.containerd.snapshotter.v1.overlayfs as the overlay filesystem for `/`.
343343
try:
344344
with open("/proc/mounts", "rt") as infile:
@@ -375,7 +375,7 @@ def in_docker():
375375
return False
376376

377377

378-
# whether in_docker check should always return True or False
378+
# whether the `in_docker` check should always return True or False
379379
OVERRIDE_IN_DOCKER = parse_boolean_env("OVERRIDE_IN_DOCKER")
380380

381381
is_in_docker = in_docker()
@@ -1454,7 +1454,7 @@ def service_port(service_key: str, external: bool = False) -> int:
14541454
def get_edge_port_http():
14551455
"""@deprecated: Use `localstack_host().port` for external and `GATEWAY_LISTEN[0].port` for
14561456
internal use. This function is not needed anymore because we don't separate between HTTP
1457-
and HTTP ports anymore since LocalStack comprehends to both."""
1457+
and HTTP ports anymore since LocalStack listens to both ports."""
14581458
warnings.warn(
14591459
"""@deprecated: Use `localstack_host().port` for external and `GATEWAY_LISTEN[0].port`
14601460
for internal use. This function is also not needed anymore because we don't separate

localstack-core/localstack/constants.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
HEADER_LOCALSTACK_TARGET = "x-localstack-target"
1313
HEADER_AMZN_ERROR_TYPE = "X-Amzn-Errortype"
1414

15-
# backend service ports, for services that are behind the proxy (counting down from 4566)
15+
# backend service ports, for services that are behind a proxy (counting down from 4566)
1616
DEFAULT_PORT_EDGE = 4566
1717

1818
# host name for localhost
@@ -33,7 +33,7 @@
3333
# Artifacts endpoint
3434
ASSETS_ENDPOINT = "https://assets.localstack.cloud"
3535

36-
# host to bind when starting the services
36+
# host to bind to when starting the services
3737
BIND_HOST = "0.0.0.0"
3838

3939
# root code folder

0 commit comments

Comments
 (0)
0