Apply suggestions from code review

thrau · dominikschubert · web-flow · commit 818d70d8bd69 · 2022-08-08T21:38:16.000+02:00
Co-authored-by: Dominik Schubert &lt;dominik.schubert91@gmail.com&gt;
diff --git a/tests/integration/awslambda/functions/lambda_sqs_integration.py b/tests/integration/awslambda/functions/lambda_sqs_integration.py
@@ -18,8 +18,8 @@
 
 def handler(event, context):
     # this lambda expects inputs from an SQS event source mapping
-    if not event.get("Records"):
-        raise ValueError("no records passed to event")
+    if len(event.get("Records", [])) != 1:
+        raise ValueError("the payload must consist of exactly one record")
 
     # it expects exactly one record where the message body is '{"destination": "<queue_url>"}' that mimics a
     # DestinationConfig (which is not possible with SQS event source mappings).
@@ -49,7 +49,4 @@ def create_external_boto_client(service):
         endpoint_url = (
             f"http://{os.environ['LOCALSTACK_HOSTNAME']}:{os.environ.get('EDGE_PORT', 4566)}"
         )
-    region_name = (
-        os.environ.get("AWS_DEFAULT_REGION") or os.environ.get("AWS_REGION") or "us-east-1"
-    )
-    return boto3.client(service, endpoint_url=endpoint_url, region_name=region_name)
+    return boto3.client(service, endpoint_url=endpoint_url)
diff --git a/tests/integration/awslambda/test_lambda_sqs_integration.py b/tests/integration/awslambda/test_lambda_sqs_integration.py
@@ -137,7 +137,6 @@ def test_failing_lambda_retries_after_visibility_timeout(
 
 @pytest.mark.skip_snapshot_verify(
     paths=[
-        # FIXME: this is most of the event source mapping unfortunately
         "$..ParallelizationFactor",
         "$..LastProcessingResult",
         "$..Topics",
@@ -158,9 +157,9 @@ def test_redrive_policy_with_failing_lambda(
     snapshot,
     cleanups,
 ):
-    """This test verifies a that SQS moves a message that is passed to a failing lambda to a DLQ according to the
+    """This test verifies that SQS moves a message that is passed to a failing lambda to a DLQ according to the
     redrive policy, and the lambda is invoked the correct number of times. The test retries twice and the event
-    source mapping should then automatically move the message to the DQL, but not earlier (see
+    source mapping should then automatically move the message to the DLQ, but not earlier (see
     https://github.com/localstack/localstack/issues/5283)"""
 
     # create queue used in the lambda to send events to (to verify lambda was invoked)
