minor

giograno · giograno · commit 443f64a3440a · 2024-08-22T15:32:38.000+02:00
diff --git a/localstack-core/localstack/aws/handlers/openapi.py b/localstack-core/localstack/aws/handlers/openapi.py
@@ -38,9 +38,9 @@ def __call__(self, chain: HandlerChain, context: RequestContext, response: Respo
             try:
                 self.openapi.validate_request(WerkzeugOpenAPIRequest(context.request))
             except OpenAPIError as e:
-                # Note: we only check request validations.
-                #   We could be more strict here and check for things such as ServerNotFound or OperationNotFound.
-                #   PathNotFound is handled by the last handler in request_handlers.
+                # Note: we only check request body validation errors, like invalid body requests or missing required
+                #   parameters. Other things we do currently explicitly check are ServerNotFound, OperationNotFound,
+                #   and PathNotFound. They are most likely intercepted in the handler chain.
                 match e:
                     case RequestValidationError():
                         response.status_code = 400
@@ -52,8 +52,7 @@ def __call__(self, chain: HandlerChain, context: RequestContext, response: Respo
 
 class OpenAPIResponseValidator(OpenAPIRequestValidator):
     def __call__(self, chain: HandlerChain, context: RequestContext, response: Response):
-        # We are more lenient in validating the responses, since there is no users fault involved.
-        #   We can eventually leverage this feature flag and be more strict in out test pipeline.
+        # We are more lenient in validating the responses. The use of this flag is intended for test.
         if not config.OPENAPI_VALIDATE_RESPONSE:
             return
 
diff --git a/localstack-core/localstack/config.py b/localstack-core/localstack/config.py
@@ -1255,6 +1255,7 @@ def use_custom_dns():
     "LS_LOG",
     "MAIN_CONTAINER_NAME",
     "MAIN_DOCKER_NETWORK",
+    "OPENAPI_VALIDATE_REQUEST",
     "OPENAPI_VALIDATE_RESPONSE",
     "OPENSEARCH_ENDPOINT_STRATEGY",
     "OUTBOUND_HTTP_PROXY",
diff --git a/localstack-core/localstack/spec.py b/localstack-core/localstack/spec.py
@@ -39,14 +39,6 @@
             "url": "http://localhost.localstack.cloud:{port}",
             "variables": {"port": {"default": "4566"}},
         },
-        {
-            "url": "http://localhost:{port}",
-            "variables": {"port": {"default": "4566"}},
-        },
-        {
-            "url": "http://127.0.0.1:{port}",
-            "variables": {"port": {"default": "4566"}},
-        },
     ],
     "components": {
         "schemas": {
