8000 rename EventPatternValidator into EventPatternCompiler as it does mor… · localstack/localstack@29652a1 · GitHub
[go: up one dir, main page]
Skip to content

Commit 29652a1

Browse files
bentskubentsku
committed
rename EventPatternValidator into EventPatternCompiler as it does more than validate the rule
1 parent 99fdcff commit 29652a1

File tree

2 files changed

+14
-11
lines changed

2 files changed

+14
-11
lines changed

‎localstack-core/localstack/services/events/event_rule_engine.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,19 +7,19 @@
77

88

99
class EventRuleEngine:
10-
def evaluate_pattern_on_event(self, event_pattern: dict, message_body: str | dict):
11-
if isinstance(message_body, str):
10+
def evaluate_pattern_on_event(self, compiled_event_pattern: dict, event: str | dict):
11+
if isinstance(event, str):
1212
try:
13-
body = json.loads(message_body)
13+
body = json.loads(event)
1414
if not isinstance(body, dict):
1515
return False
1616
except json.JSONDecodeError:
1717
# Event pattern for the message body assume that the message payload is a well-formed JSON object.
1818
return False
1919
else:
20-
body = message_body
20+
body = event
2121

22-
return self._evaluate_nested_event_pattern_on_dict(event_pattern, payload=body)
22+
return self._evaluate_nested_event_pattern_on_dict(compiled_event_pattern, payload=body)
2323

2424
def _evaluate_nested_event_pattern_on_dict(self, event_pattern, payload: dict) -> bool:
2525
"""
@@ -270,11 +270,11 @@ def _traverse(_object: dict, array=None, parent_key=None) -> list:
270270
return _traverse(nested_dict, array=[{}], parent_key=None)
271271

272272

273-
class EventPatternValidator:
273+
class EventPatternCompiler:
274274
def __init__(self):
275275
self.error_prefix = "Event pattern is not valid. Reason: "
276276

277-
def validate_event_pattern(self, event_pattern: str | dict) -> dict[str, t.Any]:
277+
def compile_event_pattern(self, event_pattern: str | dict) -> dict[str, t.Any]:
278278
if isinstance(event_pattern, str):
279279
try:
280280
event_pattern = json.loads(event_pattern)

‎localstack-core/localstack/utils/event_matcher.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22
from typing import Any
33

44
from localstack import config
5-
from localstack.services.events.event_rule_engine import EventPatternValidator, EventRuleEngine
5+
from localstack.services.events.event_rule_engine import EventPatternCompiler, EventRuleEngine
66
from localstack.services.events.event_ruler import matches_rule
77

8-
_event_pattern_validator = EventPatternValidator()
8+
_event_pattern_compiler = EventPatternCompiler()
99
_event_rule_engine = EventRuleEngine()
1010

1111

@@ -51,7 +51,10 @@ def matches_event(event_pattern: dict[str, Any] | str | None, event: dict[str, A
5151
return matches_rule(event_str, pattern_str)
5252

5353
# Python implementation (default)
54-
event_pattern_dict = _event_pattern_validator.validate_event_pattern(
54+
compiled_event_pattern = _event_pattern_compiler.compile_event_pattern(
5555
event_pattern=event_pattern
5656
)
57-
return _event_rule_engine.evaluate_pattern_on_event(event_pattern_dict, event)
57+
return _event_rule_engine.evaluate_pattern_on_event(
58+
compiled_event_pattern=compiled_event_pattern,
59+
event=event,
60+
)

0 commit comments

Comments
 (0)
0