oas validation for sqs backdoor

giograno · giograno · commit 12ea79148a1d · 2024-10-01T19:07:30.000-04:00
diff --git a/localstack-core/localstack/aws/handlers/validation.py b/localstack-core/localstack/aws/handlers/validation.py
@@ -134,7 +134,7 @@ def __call__(self, chain: HandlerChain, context: RequestContext, response: Respo
                         WerkzeugOpenAPIResponse(response),
                     )
                 except ResponseValidationError as exc:
-                    LOG.error("Response validation failed for %s: $s", path, exc)
+                    LOG.error("Response validation failed for %s: %s", path, exc)
                     response.status_code = 500
                     response.set_json({"error": exc.__class__.__name__, "message": str(exc)})
                     chain.stop()
diff --git a/localstack-core/localstack/testing/pytest/fixtures.py b/localstack-core/localstack/testing/pytest/fixtures.py
@@ -2285,3 +2285,9 @@ def _delete_log_group():
             call_safe(_delete_log_group)
 
     yield _clean_up
+
+
+@pytest.fixture
+def openapi_validate(monkeypatch):
+    monkeypatch.setattr(config, "OPENAPI_VALIDATE_RESPONSE", "true")
+    monkeypatch.setattr(config, "OPENAPI_VALIDATE_REQUEST", "true")
diff --git a/tests/aws/services/sqs/test_sqs_backdoor.py b/tests/aws/services/sqs/test_sqs_backdoor.py
@@ -26,6 +26,7 @@ def _parse_attribute_map(json_message: dict) -> dict[str, str]:
     return {attr["Name"]: attr["Value"] for attr in json_message["Attribute"]}
 
 
+@pytest.mark.usefixtures("openapi_validate")
 class TestSqsDeveloperEndpoints:
     @markers.aws.only_localstack
     @pytest.mark.parametrize("strategy", ["standard", "domain", "path"])

Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,7 @@ def __call__(self, chain: HandlerChain, context: RequestContext, response: Respo`
`134`	`134`	`WerkzeugOpenAPIResponse(response),`
`135`	`135`	`)`
`136`	`136`	`except ResponseValidationError as exc:`
`137`		`- LOG.error("Response validation failed for %s: $s", path, exc)`
	`137`	`+ LOG.error("Response validation failed for %s: %s", path, exc)`
`138`	`138`	`response.status_code = 500`
`139`	`139`	`response.set_json({"error": exc.__class__.__name__, "message": str(exc)})`
`140`	`140`	`chain.stop()`