fix test for V1

bentsku · bentsku · commit 03512db8f54f · 2024-10-16T15:48:15.000+02:00
diff --git a/tests/aws/services/dynamodbstreams/test_dynamodb_streams.py b/tests/aws/services/dynamodbstreams/test_dynamodb_streams.py
@@ -53,6 +53,7 @@ def test_table_v2_stream(self, aws_client, infrastructure_setup, snapshot):
 
     @markers.aws.only_localstack
     def test_stream_spec_and_region_replacement(self, aws_client, region_name):
+        # our V1 and V2 implementation are pretty different, and we need different ways to test it
         ddbstreams = aws_client.dynamodbstreams
         table_name = f"ddb-{short_uid()}"
         resources.create_dynamodb_table(
@@ -73,6 +74,14 @@ def test_stream_spec_and_region_replacement(self, aws_client, region_name):
         stream_tables = ddbstreams.list_streams(TableName="foo")["Streams"]
         assert len(stream_tables) == 0
 
+        if not config.DDB_STREAMS_PROVIDER_V2:
+            from localstack.services.dynamodbstreams.dynamodbstreams_api import (
+                get_kinesis_stream_name,
+            )
+
+            stream_name = get_kinesis_stream_name(table_name)
+            assert stream_name in aws_client.kinesis.list_streams()["StreamNames"]
+
         # assert stream has been created
         stream_tables = [
             s["TableName"] for s in ddbstreams.list_streams(TableName=table_name)["Streams"]
@@ -90,8 +99,15 @@ def test_stream_spec_and_region_replacement(self, aws_client, region_name):
         aws_client.dynamodb.delete_table(TableName=table_name)
 
         def _assert_stream_disabled():
-            result = aws_client.dynamodbstreams.describe_stream(StreamArn=table["LatestStreamArn"])
-            assert result["StreamDescription"]["StreamStatus"] == "DISABLED"
+            if config.DDB_STREAMS_PROVIDER_V2:
+                _result = aws_client.dynamodbstreams.describe_stream(
+                    StreamArn=table["LatestStreamArn"]
+                )
+                assert _result["StreamDescription"]["StreamStatus"] == "DISABLED"
+            else:
+                _stream_tables = [s["TableName"] for s in ddbstreams.list_streams()["Streams"]]
+                assert table_name not in _stream_tables
+                assert stream_name not in aws_client.kinesis.list_streams()["StreamNames"]
 
         # assert stream has been deleted
         retry(_assert_stream_disabled, sleep=1, retries=20)
