8000 fix: phoenixd pending payments by dni · Pull Request #3075 · lnbits/lnbits · GitHub
[go: up one dir, main page]
Skip to content

fix: phoenixd pending payments #3075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from
Draft

fix: phoenixd pending payments #3075

wants to merge 5 commits into from
+92 −30

Conversation

dni
Copy link
Member
@dni dni commented Mar 31, 2025
  • if phoenixd return 404 on incoming payments the invoice was either never created or is expired
  • if phoenixd return 404 on outgoing they were never created

@codecov Codecov
Copy link
codecov bot commented Mar 31, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 6.38298% with 44 lines in your changes missing coverage. Please review.

Project coverage is 55.87%. Comparing base (e6de66e) to head (451bd19).

Files with missing lines Patch % Lines
lnbits/wallets/phoenixd.py 6.38% 44 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #3075      +/-   ##
==========================================
- Coverage   60.37%   55.87%   -4.50%     
==========================================
  Files         105      105              
  Lines       13668    13689      +21     
==========================================
- Hits         8252     7649     -603     
- Misses       5416     6040     +624

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dni dni force-pushed the fix/incoming-payment-fees branch from f14219b to a323011 Compare April 2, 2025 11:23
@dni dni force-pushed the fix/incoming-payment-fees branch from 71d56dd to b91cee0 Compare May 5, 2025 09:02
@dni dni marked this pull request as draft May 5, 2025 09:04
@dni dni closed this May 12, 2025
@blackcoffeexbt
Copy link
Collaborator

@motorina0 this would be a useful PR to deal with phoenixd with many pending invoices. Can we reopen the PR? For example, I have an instance with nearly 4000 pending invoices.

@motorina0 motorina0 reopened this May 28, 2025
dni added 5 commits May 28, 2025 12:09
@dni @motorina0
fix: phoenixd pending payments
f8f042a 
- if phoenixd return 404 on incoming payments the invoice was either
never created or is expired
- if phoenixd return 404 on outgoing they were never created
@dni @motorina0
except timeout
4ad463d
@dni @motorina0
missing pending
5ede13b
@dni @motorina0
queries for failed were missing
81E2 625830f
@dni @motorina0
requesterror
451bd19
@motorina0 motorina0 force-pushed the fix/incoming-payment-fees branch from b91cee0 to 451bd19 Compare May 28, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dni @blackcoffeexbt @motorina0
0