[sanitizer] Disable InstallAtForkHandler on Solaris, NetBSD #75659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Vitaly Buka (vitalybuka) ChangesHandlers need missing FutexWait implementation. Full diff: https://github.com/llvm/llvm-project/pull/75659.diff 3 Files Affected:
diff --git a/compiler-rt/lib/asan/asan_posix.cpp b/compiler-rt/lib/asan/asan_posix.cpp
index 206551b6ef910e..0d2e4fe0176772 100644
--- a/compiler-rt/lib/asan/asan_posix.cpp
+++ b/compiler-rt/lib/asan/asan_posix.cpp
@@ -149,6 +149,9 @@ void PlatformTSDDtor(void *tsd) {
#endif
void InstallAtForkHandler() {
+# if SANITIZER_SOLARIS || SANITIZER_NETBSD
+ return; // FIXME: Implement FutexWait.
+# endif
auto before = []() {
if (CAN_SANITIZE_LEAKS) {
__lsan::LockGlobal();
diff --git a/compiler-rt/lib/lsan/lsan_posix.cpp b/compiler-rt/lib/lsan/lsan_posix.cpp
index 3677f0141a2f02..e0c1899edcd2cf 100644
--- a/compiler-rt/lib/lsan/lsan_posix.cpp
+++ b/compiler-rt/lib/lsan/lsan_posix.cpp
@@ -101,6 +101,9 @@ void InstallAtExitCheckLeaks() {
}
void InstallAtForkHandler() {
+# if SANITIZER_SOLARIS || SANITIZER_NETBSD
+ return; // FIXME: Implement FutexWait.
+# endif
auto before = []() {
LockGlobal();
LockThreads();
diff --git a/compiler-rt/test/sanitizer_common/TestCases/Posix/fork_threaded.c b/compiler-rt/test/sanitizer_common/TestCases/Posix/fork_threaded.c
index 6c5102049ae8ef..5c6a8743cdb580 100644
--- a/compiler-rt/test/sanitizer_common/TestCases/Posix/fork_threaded.c
+++ b/compiler-rt/test/sanitizer_common/TestCases/Posix/fork_threaded.c
@@ -12,6 +12,10 @@
// FIXME: False stack overflow report
// UNSUPPORTED: android && asan
+// FIXME: Requires `FutexWait` implementation. See __asan::InstallAtForkHandler.
+// UNSUPPORTED: target={{.*solaris.*}}
+// UNSUPPORTED: target={{.*netbsd.*}}
+
// Forking in multithread environment is unsupported. However we already have
// some workarounds, and will add more, so this is the test.
// The test try to check two things:
|
thurstond
approved these changes
Dec 15, 2023
MaskRay
approved these changes
Dec 15, 2023
|
I've just successfully tested the patch on |
rorth
approved these changes
Dec 16, 2023
|
This was needed for Darwin too — 2a03854. |
|
On one hand, that's not surprising given what I reported in [asan] Install pthread_atfork #75290 about the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handlers need missing FutexWait implementation.
Reported in #75290.