Fix race condition during iteration through modules (#139283)

nd-work · nd-work · commit 2fd4a90eaa2d · 2025-05-14T11:09:07.000+02:00
Lock ensures modules don't change during iteration.
diff --git a/lldb/source/Target/Target.cpp b/lldb/source/Target/Target.cpp
@@ -1510,6 +1510,7 @@ bool Target::IgnoreWatchpointByID(lldb::watch_id_t watch_id,
 }
 
 ModuleSP Target::GetExecutableModule() {
+  std::lock_guard<std::recursive_mutex> guard(m_images.GetMutex());
   // search for the first executable in the module list
   for (size_t i = 0; i < m_images.GetSize(); ++i) {
     ModuleSP module_sp = m_images.GetModuleAtIndex(i);

Original file line number	Diff line number	Diff line change
`@@ -1510,6 +1510,7 @@ bool Target::IgnoreWatchpointByID(lldb::watch_id_t watch_id,`
`1510`	`1510`	`}`
`1511`	`1511`
`1512`	`1512`	`ModuleSP Target::GetExecutableModule() {`
	`1513`	`+ std::lock_guard<std::recursive_mutex> guard(m_images.GetMutex());`
`1513`	`1514`	`// search for the first executable in the module list`
`1514`	`1515`	`for (size_t i = 0; i < m_images.GetSize(); ++i) {`
`1515`	`1516`	`ModuleSP module_sp = m_images.GetModuleAtIndex(i);`