Explicitly check if title is None. fixes buriy#22

zacharydenton · zacharydenton · commit 0843d9cdf244 · 2012-07-09T05:22:23.000-04:00
This fixes buriy#22 which caused all titles to be blank.
diff --git a/readability/htmls.py b/readability/htmls.py
@@ -44,7 +44,7 @@ def norm_title(title):
 
 def get_title(doc):
     title = doc.find('.//title')
-    if not title or not title.text:
+    if title is None or len(title.text) == 0:
         return '[no-title]'
 
     return norm_title(title.text)
@@ -57,7 +57,7 @@ def add_match(collection, text, orig):
 
 def shorten_title(doc):
     title = doc.find('.//title')
-    if not title or not title.text:
+    if title is None or len(title.text) == 0:
         return ''
 
     title = orig = norm_title(title.text)
