8000 Fixed memory leak in test fixture · littlestrange/ArduinoJson@e8c127a · GitHub
[go: up one dir, main page]

Skip to content

Commit e8c127a

Browse files
committed
Fixed memory leak in test fixture
1 parent d7ac7ff commit e8c127a

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

test/StringBuilderTests.cpp

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,18 +11,22 @@ using namespace ArduinoJson::Internals;
1111

1212
class StringBuilderTests : public testing::Test {
1313
protected:
14-
virtual void SetUp() { sb = new StringBuilder(buffer, sizeof(buffer)); }
14+
virtual void SetUp() {
15+
_stringBuilder = new StringBuilder(_buffer, sizeof(_buffer));
16+
}
1517

16-
void print(const char *value) { returnValue = sb->print(value); }
18+
virtual void TearDown() { delete _stringBuilder; }
1719

18-
void outputMustBe(const char *expected) { EXPECT_STREQ(expected, buffer); }
20+
void print(const char *value) { _returnValue = _stringBuilder->print(value); }
1921

20-
void resultMustBe(size_t expected) { EXPECT_EQ(expected, returnValue); }
22+
void outputMustBe(const char *expected) { EXPECT_STREQ(expected, _buffer); }
23+
24+
void resultMustBe(size_t expected) { EXPECT_EQ(expected, _returnValue); }
2125

2226
private:
23-
char buffer[20];
24-
Print *sb;
25-
size_t returnValue;
27+
char _buffer[20];
28+
Print *_stringBuilder;
29+
size_t _returnValue;
2630
};
2731

2832
TEST_F(StringBuilderTests, InitialState) { outputMustBe(""); }

0 commit comments

Comments
 (0)
0