chore: Skip set_sdp_fmtp_line if sdpFmtpLine is empty.

cloudwebrtc · cloudwebrtc · commit 8d4efb5fde8c · 2023-08-07T08:24:12.000+08:00
diff --git a/android/src/main/java/com/cloudwebrtc/webrtc/PeerConnectionObserver.java b/android/src/main/java/com/cloudwebrtc/webrtc/PeerConnectionObserver.java
@@ -1053,7 +1053,7 @@ public void rtpTransceiverSetCodecPreferences(String transceiverId, List<Map<Str
             codecCapability.clockRate = (int) codec.get("clockRate");
             if(codec.get("numChannels") != null)
                 codecCapability.numChannels = (int) codec.get("numChannels");
-            if(codec.get("sdpFmtpLine") != null) {
+            if(codec.get("sdpFmtpLine") != null && codec.get("sdpFmtpLine") != "") {
                 String sdpFmtpLine = (String) codec.get("sdpFmtpLine");
                 codecCapability.parameters = new HashMap<>();
                 String[] parameters = sdpFmtpLine.split(";");
diff --git a/common/cpp/src/flutter_peerconnection.cc b/common/cpp/src/flutter_peerconnection.cc
@@ -801,7 +801,7 @@ void FlutterPeerConnection::RtpTransceiverSetCodecPreferences(
     auto codecNumChannels = findInt(codecMap, "channels");
     auto codecSdpFmtpLine = findString(codecMap, "sdpFmtpLine");
     auto codecCapability = RTCRtpCodecCapability::Create();
-    if (codecSdpFmtpLine != std::string())
+    if (codecSdpFmtpLine != std::string() && codecSdpFmtpLine.length() != 0)
       codecCapability->set_sdp_fmtp_line(codecSdpFmtpLine);
     codecCapability->set_clock_rate(codecClockRate);
     if (codecNumChannels != -1)
diff --git a/common/darwin/Classes/FlutterRTCPeerConnection.m b/common/darwin/Classes/FlutterRTCPeerConnection.m
@@ -817,7 +817,7 @@ - (void)transceiverSetCodecPreferences:(nonnull NSDictionary*)argsMap
     codec.clockRate = c[@"clockRate"];
     codec.kind = mediaTypeFromString([kindAndName[0] lowercaseString]);
     codec.name = kindAndName[1];
-    if (c[@"sdpFmtpLine"] != nil) {
+    if (c[@"sdpFmtpLine"] != nil && ![((NSString*)c[@"sdpFmtpLine"]) isEqualToString:@""]) {
       codec.parameters = stringToParameters((NSString*)c[@"sdpFmtpLine"]);
     }
     if (c[@"channels"] != nil) {

Original file line number	Diff line number	Diff line change
`@@ -817,7 +817,7 @@ - (void)transceiverSetCodecPreferences:(nonnull NSDictionary*)argsMap`
`817`	`817`	`codec.clockRate = c[@"clockRate"];`
`818`	`818`	`codec.kind = mediaTypeFromString([kindAndName[0] lowercaseString]);`
`819`	`819`	`codec.name = kindAndName[1];`
`820`		`- if (c[@"sdpFmtpLine"] != nil) {`
	`820`	`+ if (c[@"sdpFmtpLine"] != nil && ![((NSString*)c[@"sdpFmtpLine"]) isEqualToString:@""]) {`
`821`	`821`	`codec.parameters = stringToParameters((NSString*)c[@"sdpFmtpLine"]);`
`822`	`822`	`}`
`823`	`823`	`if (c[@"channels"] != nil) {`