8000 Error with definition of method getContainer and Symfony 5.3 · Issue #583 · liip/LiipFunctionalTestBundle · GitHub
[go: up one dir, main page]

Skip to content
Error with definition of method getContainer and Symfony 5.3 #583
@k20human

Description

@k20human

Preconditions

  1. Bundle version : 4.3.1
  2. Symfony version : 5.3

Steps to reproduce

  1. Create a test class that extends Liip\FunctionalTestBundle\Test\WebTestCase
  2. Create a test
  3. Run the test

Expected result

  1. Test run without error

Actual result

An error occured:

In WebTestCase.php line 205:
                                                                                                                                                                              
Compile Error: Cannot make static method Symfony\Bundle\FrameworkBundle\Test\KernelTestCase::getContainer() non static in class Liip\FunctionalTestBundle\Test\WebTestCase 

It's due to this PR on SF 5.3 : symfony/symfony#40366

I can propose a PR to fix that. Can we remove getContainer method from WebTestCase and use SF's one ? Or rename it ? Or other thing ?

For now i copy / paste WebTestCase class in my code and remove the getContainer method. All tests run like before

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0