Remove “skip certificate check” option

jspahrsummers · jspahrsummers · commit d2bdd34a29e3 · 2014-09-24T14:00:44.000-07:00
The libgit2 facility for skipping certificate checks was removed and
replaced with a much more general—but harder to use—API, so it’s easier
to remove this for now.

See the libgit2 CHANGELOG for more information.
diff --git a/Classes/GTRepository.h b/Classes/GTRepository.h
@@ -81,10 +81,7 @@ typedef NS_OPTIONS(NSInteger, GTCheckoutNotifyFlags) {
 
 /// Transport flags sent as options to +cloneFromURL... method
 typedef NS_OPTIONS(NSInteger, GTTransportFlags) {
-	GTTransportFlagsNone = GIT_TRANSPORTFLAGS_NONE,
-	// If you pass this flag and the connection is secured with SSL/TLS,
-	// the authenticity of the server certificate will not be verified.
-	GTTransportFlagsNoCheckCert = GIT_TRANSPORTFLAGS_NO_CHECK_CERT,
+	GTTransportFlagsNone = GIT_TRANSPORTFLAGS_NONE
 };
 
 /// An `NSNumber` wrapped `GTTransportFlags`, documented above.
diff --git a/Classes/GTRepository.m b/Classes/GTRepository.m
@@ -196,15 +196,11 @@ static int remoteCreate(git_remote **remote, git_repository *repo, const char *n
 	if ((error = git_remote_create(remote, repo, name, url)) < 0)
 		return error;
 	
-	if (pld->ignoreCertErrors)
-		git_remote_check_cert(*remote, !pld->ignoreCertErrors);
-	
 	return git_remote_set_callbacks(*remote, callbacks);
 }
 
 struct GTRemoteCreatePayload {
 	git_remote_callbacks remoteCallbacks;
-	BOOL ignoreCertErrors;
 };
 
 + (id)cloneFromURL:(NSURL *)originURL toWorkingDirectory:(NSURL *)workdirURL options:(NSDictionary *)options error:(NSError **)error transferProgressBlock:(void (^)(const git_transfer_progress *))transferProgressBlock checkoutProgressBlock:(void (^)(NSString *path, NSUInteger completedSteps, NSUInteger totalSteps))checkoutProgressBlock {
@@ -240,12 +236,9 @@ + (id)cloneFromURL:(NSURL *)originURL toWorkingDirectory:(NSURL *)workdirURL opt
 
 	cloneOptions.remote_callbacks.transfer_progress = transferProgressCallback;
 	cloneOptions.remote_callbacks.payload = &payload;
-	
-	NSNumber *transportFlags = options[GTRepositoryCloneOptionsTransportFlags];
 
 	struct GTRemoteCreatePayload remoteCreatePayload;
 	remoteCreatePayload.remoteCallbacks = cloneOptions.remote_callbacks;
-	remoteCreatePayload.ignoreCertErrors = (transportFlags == nil ? 0 : 1);
 	
 	cloneOptions.remote_cb = remoteCreate;
 	cloneOptions.remote_cb_payload = &remoteCreatePayload;
