8000 Return GTOIDs instead of GTCommits · libgit2/objective-git@28afdb8 · GitHub
[go: up one dir, main page]

Skip to content

Commit 28afdb8

Browse files
committed
Return GTOIDs instead of GTCommits
1 parent 6323ca5 commit 28afdb8

File tree

3 files changed

+9
-12
lines changed

3 files changed

+9
-12
lines changed

ObjectiveGit/GTRepository+Merging.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,14 @@ typedef NS_OPTIONS(NSInteger, GTMergeAnalysis) {
3434
/// enumeration to stop after the block returns. Must not be nil.
3535
///
3636
/// Returns YES if the operation succedded, NO otherwise.
37-
- (BOOL)enumerateMergeHeadEntriesWithError:(NSError **)error usingBlock:(void (^)(GTCommit *mergeHeadEntry, BOOL *stop))block;
37+
- (BOOL)enumerateMergeHeadEntriesWithError:(NSError **)error usingBlock:(void (^)(GTOID *mergeHeadEntry, BOOL *stop))block;
3838

3939
/// Convenience method for -enumerateMergeHeadEntriesWithError:usingBlock: that retuns an NSArray with all the fetch head entries.
4040
///
4141
/// error - The error if one ocurred. Can be NULL.
4242
///
43-
/// Retruns a (possibly empty) array with GTCommit objects. Will not be nil.
44-
- (NSArray <GTCommit *>*)mergeHeadEntriesWithError:(NSError **)error;
43+
/// Retruns a (possibly empty) array with GTOID objects. Will not be nil.
44+
- (NSArray <GTOID *>*)mergeHeadEntriesWithError:(NSError **)error;
4545

4646
/// Merge Branch into current branch
4747
///

ObjectiveGit/GTRepository+Merging.m

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,33 +22,30 @@
2222

2323
@implementation GTRepository (Merging)
2424

25-
typedef void (^GTRepositoryEnumerateMergeHeadEntryBlock)(GTCommit *entry, BOOL *stop);
25+
typedef void (^GTRepositoryEnumerateMergeHeadEntryBlock)(GTOID *entry, BOOL *stop);
2626

2727
typedef struct {
28-
__unsafe_unretained GTRepository *repository;
2928
__unsafe_unretained GTRepositoryEnumerateMergeHeadEntryBlock enumerationBlock;
3029
} GTEnumerateMergeHeadEntriesPayload;
3130

3231
int GTMergeHeadEntriesCallback(const git_oid *oid, void *payload) {
3332
GTEnumerateMergeHeadEntriesPayload *entriesPayload = payload;
3433

35-
GTRepository *repository = entriesPayload->repository;
3634
GTRepositoryEnumerateMergeHeadEntryBlock enumerationBlock = entriesPayload->enumerationBlock;
3735

38-
GTCommit *commit = [repository lookUpObjectByOID:[GTOID oidWithGitOid:oid] objectType:GTObjectTypeCommit error:NULL];
36+
GTOID *gtoid = [GTOID oidWithGitOid:oid];
3937

4038
BOOL stop = NO;
4139

42-
enumerationBlock(commit, &stop);
40+
enumerationBlock(gtoid, &stop);
4341

4442
return (stop == YES ? GIT_EUSER : 0);
4543
}
4644

47-
- (BOOL)enumerateMergeHeadEntriesWithError:(NSError **)error usingBlock:(void (^)(GTCommit *mergeHeadEntry, BOOL *stop))block {
45+
- (BOOL)enumerateMergeHeadEntriesWithError:(NSError **)error usingBlock:(void (^)(GTOID *mergeHeadEntry, BOOL *stop))block {
4846
NSParameterAssert(block != nil);
4947

5048
GTEnumerateMergeHeadEntriesPayload payload = {
51-
.repository = self,
5249
.enumerationBlock = block,
5350
};
5451

@@ -65,7 +62,7 @@ - (BOOL)enumerateMergeHeadEntriesWithError:(NSError **)error usingBlock:(void (^
6562
- (NSArray *)mergeHeadEntriesWithError:(NSError **)error {
6663
NSMutableArray *entries = [NSMutableArray array];
6764

68-
[self enumerateMergeHeadEntriesWithError:error usingBlock:^(GTCommit *mergeHeadEntry, BOOL *stop) {
65+
[self enumerateMergeHeadEntriesWithError:error usingBlock:^(GTOID *mergeHeadEntry, BOOL *stop) {
6966
[entries addObject:mergeHeadEntry];
7067

7168
*stop = NO;

ObjectiveGitTests/GTRepository+PullSpec.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@
260260
expect(error.domain).to(equal(@"GTGitErrorDomain"));
261261
expect(error.userInfo[GTPullMergeConflictedFiles]).to(equal(@[@"test.txt"]));
262262
expect(fileContents).notTo(equal(@"TestLocal"));
263-
expect([localRepo mergeHeadEntriesWithError:nil]).to(equal(@[remoteCommit]));
263+
expect([localRepo mergeHeadEntriesWithError:nil]).to(equal(@[remoteCommit.OID]));
264264
expect([localRepo preparedMessageWithError:nil]).to(beginWith(@"Merge commit"));
265265
expect(error.localizedDescription).to(equal(@"Merge conflict"));
266266
expect(@(transferProgressed)).to(beTruthy());

0 commit comments

Comments
 (0)
0