8000 Move FindMergeBase() overloads to ObjectDatabase · Issue #951 · libgit2/libgit2sharp · GitHub
[go: up one dir, main page]
Skip to content

Move FindMergeBase() overloads to ObjectDatabase #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks
nulltoken opened this issue Feb 11, 2015 · 5 comments
Closed
4 tasks

Move FindMergeBase() overloads to ObjectDatabase #951

nulltoken opened this issue Feb 11, 2015 · 5 comments
Labels
in-progress Stabilization
Milestone
v0.22

Comments

@nulltoken
Copy link
Member
  • Deprecate IQueryableCommitLog.FindMergeBase()
  • Move CommitLog.FindMergeBase() implementation to ObjectDatabase.FindMergeBase()
  • Make CommitLog.FindMergeBase() delegate to ObjectDatabase.FindMergeBase()
  • Deprecate CommitLog.FindMergeBase()
@bording
Copy link
Member
bording commented Feb 12, 2015

I think this issue and #864 are the same thing. They both have the up for grabs tag, so would it be cool if I take a look at this? This looks like it should be pretty easy to revise, and I've been wanting to find a good entry point to contributing!

@bording
Copy link
Member
bording commented Feb 12, 2015

I went ahead and gave it a try. If it's something you're ok with me doing, I'll open a PR for it.

If not, well no big deal, I still got to play around in the codebase a bit!

@jamill
Copy link
Member
jamill commented Feb 12, 2015

@bording Thanks and welcome to the project!

I think it would be great if this was something you wanted to take a look at! I haven't looked at the changes in detail, but if you wanted to open a PR, that would make it easier to proceed. Thanks!

@nulltoken
Copy link
Member Author

I think this issue and #864 are the same thing

@bording Indeed 😊. I closed the other one, stole the description from it as it was more accurate and marked this one as in-progress.

It's all yours.

@bording bording mentioned this issue Feb 12, 2015
Merged
@nulltoken nulltoken added this to the v0.22 milestone Feb 12, 2015
@nulltoken
Copy link
Member Author

Fixed by #957

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in-progress Stabilization
Projects
None yet
Milestone
v0.22
Development

No branches or pull requests
3 participants
@nulltoken @bording @jamill
0