8000 NuGet package - Don't create dependency on absolute path to the package in .csproj · Issue #792 · libgit2/libgit2sharp · GitHub
[go: up one dir, main page]

Skip to content
NuGet package - Don't create dependency on absolute path to the package in .csproj #792
Closed
@zlamma

Description

@zlamma

Hi, one thing I would be glad to see improve in this package is the way the files are copied to the bin folder. Inside the PostBuildEvent added by the package to the .csproj the xcopy command contains an absolute path rooted at the drive letter, e.g.
xcopy /s /y /d "C:\Devel\packages\lib\net40\NativeBinaries\x86_._" "$(TargetDir)NativeBinaries\x86"

This makes the sources not portable to directory structure of other
developers.

Perhaps you can consider simply adding the files to the project as
with CopyToOutputDirectory=PreserveNewest (under the NativeBinaries folder, which will get preserved when copying), or using some smarts to make the path in the xcopy command relative to $(MSBuildProjectDirectory), just like the dlls reference's HintPath is.

Thanks in advance.

And thanks for maintaining this package!

Regards Slawomir

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0