Make Repository.IsValid() return false on empty paths

ptr1120 · nulltoken · commit dd8f6da8b33a · 2015-07-14T19:32:02.000+02:00
Fix #818
diff --git a/LibGit2Sharp.Tests/RepositoryFixture.cs b/LibGit2Sharp.Tests/RepositoryFixture.cs
@@ -57,6 +57,26 @@ public void CanCheckIfADirectoryLeadsToAValidRepository()
             Assert.False(Repository.IsValid(scd.DirectoryPath));
         }
 
+
+        [Fact]
+        public void IsValidWithNullPathThrows()
+        {
+            Assert.Throws<ArgumentNullException>(() => Repository.IsValid(null));
+        }
+
+        [Fact]
+        public void IsNotValidWithEmptyPath()
+        {
+            Assert.False(Repository.IsValid(string.Empty));
+        }
+
+        [Fact]
+        public void IsValidWithValidPath()
+        {
+            string repoPath = InitNewRepository();
+            Assert.True(Repository.IsValid(repoPath));
+        }
+
         [Fact]
         public void CanCreateStandardRepo()
         {
diff --git a/LibGit2Sharp/Repository.cs b/LibGit2Sharp/Repository.cs
@@ -155,7 +155,12 @@ public Repository(string path, RepositoryOptions options)
         /// <returns>True if a repository can be resolved through this path; false otherwise</returns>
         static public bool IsValid(string path)
         {
-            Ensure.ArgumentNotNullOrEmptyString(path, "path");
+            Ensure.ArgumentNotNull(path, "path");
+
+            if (string.IsNullOrWhiteSpace(path))
+            {
+                return false;
+            }
 
             try
             {

Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,12 @@ public Repository(string path, RepositoryOptions options)`
`155`	`155`	`/// <returns>True if a repository can be resolved through this path; false otherwise</returns>`
`156`	`156`	`static public bool IsValid(string path)`
`157`	`157`	`{`
`158`		`- Ensure.ArgumentNotNullOrEmptyString(path, "path");`
	`158`	`+ Ensure.ArgumentNotNull(path, "path");`
	`159`	`+`
	`160`	`+ if (string.IsNullOrWhiteSpace(path))`
	`161`	`+ {`
	`162`	`+ return false;`
	`163`	`+ }`
`159`	`164`
`160`	`165`	`try`
`161`	`166`	`{`