8000 Allow proxy options when connecting with a detached remote. by lrm29 · Pull Request #6058 · libgit2/libgit2 · GitHub
[go: up one dir, main page]
Skip to content

Allow proxy options when connecting with a detached remote. #6058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 20, 2021
Merged

Allow proxy options when connecting with a detached remote. #6058

merged 4 commits into from
Sep 20, 2021

Conversation

lrm29
Copy link
Contributor
@lrm29 lrm29 commented Sep 16, 2021 •
edited
Loading

Fixes #6059.

@lrm29 lrm29 marked this pull request as ready for review September 16, 2021 11:17
ethomson
ethomson requested changes Sep 18, 2021
View reviewed changes
Copy link
Member
@ethomson ethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we can avoid keeping this cleanup_config variable by getting a refcounted pointer for the repository's config, instead of a weak pointer. Then we'll just free it always. There's no real overhead to getting a regular config and git_config_freeing it, the only real advantage to weak pointers is that you don't need to worry about freeing them.

@ethomson
Copy link
Member

Thanks for this! I might recommend a minor cleanup.

lrm29 and others added 2 commits September 18, 2021 21:00
@lrm29
Apply suggestions from code review
c8823fb 
Co-authored-by: Edward Thomson <ethomson@github.com>
@lrm29
Update remote.c
3bd462a 
Initialise cfg variable.
@lrm29 lrm29 requested a review from ethomson September 18, 2021 20:23
@ethomson
Copy link
Member

Looks good to me! Thanks for the fix!

@ethomson ethomson merged commit 0644c2e into libgit2:main Sep 20, 2021
@lrm29 lrm29 deleted the proxy_config_with_detached_remote branch September 28, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethomson ethomson Awaiting requested review from ethomson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow proxy options when connecting with a detached remote.
2 participants
@lrm29 @ethomson
0