CMake: vendor strings #1580
Merged
CMake: vendor strings #1580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| EXECUTE_PROCESS(COMMAND "${GIT_EXECUTABLE}" describe --tags OUTPUT_VARIABLE DESCRIBE_OUTPUT) | ||
| STRING(REGEX REPLACE "^v(.*)\n$" "\\1" EXTENDED_VERSION "${DESCRIBE_OUTPUT}") | ||
| STRING(REGEX REPLACE "-" "." LIBGIT2_VERSION_STRING "${EXTENDED_VERSION}") | ||
| ADD_DEFINITIONS(-DLIBGIT2_VERSION="\"${LIBGIT2_VESION_STRING}\"") |
There was a problem hiding this comment.
Shouldn't it be LIBGIT2_VE R SION_STRING?
This helps us install multiple versions of the library side-by-side.
|
Seems simple enough. There are some other CMake options that seem to do something similar, but I don't see any reason to prefer them over this approach. |
phatblat
pushed a commit
to phatblat/libgit2
that referenced
this pull request
Sep 13, 2014
CMake: vendor strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps us install multiple versions of the library side-by-side.
BOOM! /cc @nulltoken @ben