8000 Add SecCopyErrorMessageString for iOS · Issue #6861 · libgit2/libgit2 · GitHub
[go: up one dir, main page]
Skip to content

Add SecCopyErrorMessageString for iOS #6861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Kyle-Ye opened this issue Aug 17, 2024 · 0 comments · Fixed by #6862
Closed

Add SecCopyErrorMessageString for iOS #6861

Kyle-Ye opened this issue Aug 17, 2024 · 0 comments · Fixed by #6862

Comments

@Kyle-Ye
Copy link
Contributor
Kyle-Ye commented Aug 17, 2024

SecCopyErrorMessageString is introduced to iOS since iOS 11.3 (29 March 2018)

https://developer.apple.com/documentation/security/1394686-seccopyerrormessagestring?language=objc

libgit2/src/libgit2/streams/stransport.c

Lines 29 to 38 in 4d38f13

#if !TARGET_OS_IPHONE
message = SecCopyErrorMessageString(ret, NULL);
GIT_ERROR_CHECK_ALLOC(message);
git_error_set(GIT_ERROR_NET, "SecureTransport error: %s", CFStringGetCStringPtr(message, kCFStringEncodingUTF8));
CFRelease(message);
#else
git_error_set(GIT_ERROR_NET, "SecureTransport error: OSStatus %d", (unsigned int)ret);
GIT_UNUSED(message);
#endif

This is a easy to fix issue. I'd like to file a PR to fix it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add SecCopyErrorMessageString for iOS and update README for iOS Kyle-Ye/libgit2
1 participant
@Kyle-Ye
0