8000 Win32: CMake missing secur32 link dependency for auth_sspi · Issue #6710 · libgit2/libgit2 · GitHub
[go: up one dir, main page]
Skip to content

Win32: CMake missing secur32 link dependency for auth_sspi #6710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
8000
mrjoel opened this issue Dec 30, 2023 · 3 comments
Closed

Win32: CMake missing secur32 link dependency for auth_sspi #6710

mrjoel opened this issue Dec 30, 2023 · 3 comments

Comments

@mrjoel
Copy link
mrjoel commented Dec 30, 2023

Reproduction steps

Build on Windows using USE_HTTPS=OpenSSL

Expected behavior

Build succeeds

Actual behavior

Link error due to missing symbols, including FreeContextBuffer and CompleteAuthToken. These are added in #6533 with src/libgit2/transports/auth_sspi.c being included unconditionally, and yet not added to LIBGIT2_SYSTEM_LIBS in cmake/SelectHTTPSBackend.cmake.

Either inclusion of system libs for the OpenSSL path, or conditional building of auth_sspi seems workable.

Version of libgit2 (release number or SHA1)

1.7.0 or later

Operating system(s) tested

Windows 10
@mrjoel
Copy link
Author
mrjoel commented Dec 30, 2023

Looking further at master for reference in writeup, this turns out to already be fixed with 86872834c5f but hasn't yet made a release. Any chance of a release soon including that fix?

@ethomson
Copy link
Member

Yes - we're past due for a release. I'm looking forward to v1.8 early in the new year. I'd like to land #6679 first. 🙏

@mrjoel
Copy link
Author
mrjoel commented Dec 30, 2023

Sounds good, thanks. In the meantime I'll close this with the reference to the commit fixing it, I can backport it onto our internal branch for the time being.

@mrjoel mrjoel closed this as completed Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrjoel @ethomson
0