8000 Certificate callback needs to provide port information when appropriate · Issue #6515 · libgit2/libgit2 · GitHub

Certificate callback needs to provide port information when appropriate #6515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

ethomson opened this issue Feb 28, 2023 · 1 comment

Labels

p1

Member

ethomson commented

We reverted #6503 since it's ambiguous between host + port and IPv6 address (#6510).

Either:

provide ipv6 addresses in bracketed form -- we should have a canonical form for ipv6 addresses that we emit and possibly limit our acceptance as well, or
update the callback to have a port number, or
both

ethomson mentioned this issue

certificate callback can't differentiate IPv6 and a port #6510

Closed

Contributor

fxcoudert commented

I am willing to provide a PR, if you indicate which solution you prefer. It would be great to fix this issue.

ethomson added the p1 label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

0