8000 Tracking: Release 0.99 · Issue #5407 · libgit2/libgit2 · GitHub
[go: up one dir, main page]
Skip to content
8000

Tracking: Release 0.99 #5407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
ethomson opened this issue Feb 18, 2020 · 10 comments
Closed
3 tasks done

Tracking: Release 0.99 #5407

ethomson opened this issue Feb 18, 2020 · 10 comments

Comments

@ethomson
Copy link
Member
ethomson commented Feb 18, 2020 •
edited by pks-t
Loading

What do we need to do to land 0.99?
@ethomson
Copy link
Member Author

I'm on the fence for #5391 - it looks ok, but looks can be deceiving. But when I remind myself that this is really a 1.0 prerelease, and we we're calling it 0.99 to get people to use it, then I'm more okay with it. Thoughts?

@ethomson
Copy link
Member Author

/cc @pks-t I just wanted to have all the necessary next steps captured in one place.

@pks-t
Copy link
Member
pks-t commented Feb 18, 2020

Yup, makes sense.

I'm against #5391, even if we label this a prerelease. It's not fixing any real reported issues, so I don't see the point in getting it in. We can still get it in after v0.99 in preparation of v1.0 as a nice cleanup, though.

With regards to the release script #5372, my plan is to merge this in the same breath with #5291 when doing the release so that I can see if there's any unexpected issues with resulting artifacts and fix them right away.

I'd nominate #5406 as a candidate to get our ARM builds fixed, though. Seems a bit awkward to do a release of code that we weren't able to verify with our own testing infra.

@ethomson
Copy link
Member Author

#5406 is in 🚀

@pks-t
Copy link
Member
pks-t commented Feb 18, 2020

Ah, didn't realize that, perfect!
8000

@ethomson
Copy link
Member Author

I cut #5391, I agree with your reasoning.

@ethomson
Copy link
Member Author

OK, I'm going to let you cut the release, since you're the keeper of the release script - that way you can adapt as needed if anything goes wrong. 🍾

@pks-t
Copy link
Member
pks-t commented Feb 18, 2020

OK, I'm going to let you cut the release, since you're the keeper of the release script - that way you can adapt as needed if anything goes wrong.

👍

Do we still need any amendments to #5291 or is the changelog up to date?

@ethomson
Copy link
Member Author

Do we still need any amendments to #5291 or is the changelog up to date?

Thanks for the reminder - I added a note about your changes to the FETCH_HEAD. Otherwise, the only changes were around CI and a bugfix in code that hadn't-yet-shipped!

@pks-t
Copy link
Member
pks-t commented Feb 19, 2020

Release v0.99 is out now, so I'm closing this issue! 🎉

@pks-t pks-t closed this as completed Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ethomson @pks-t
0