You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If users have http.proxy unset for a URL, libgit2 doesn't set the option WINHTTP_OPTION_PROXY to WINHTTP_ACCESS_TYPE_NO_PROXY and the system proxy is used (returned by "netsh winhttp show proxy"). Relevant code is here:
reacted with thumbs up emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Hi,
If users have http.proxy unset for a URL, libgit2 doesn't set the option WINHTTP_OPTION_PROXY to WINHTTP_ACCESS_TYPE_NO_PROXY and the system proxy is used (returned by "netsh winhttp show proxy"). Relevant code is here:
libgit2/src/libgit2/transports/winhttp.c
Line 480 in 53c5cdb
This behaviour surprises users. Should libgit2 set WINHTTP_OPTION_PROXY to WINHTTP_ACCESS_TYPE_NO_PROXY if the proxy for a URL is unset?
Thanks,
Laurence
Beta Was this translation helpful? Give feedback.
All reactions