Avoid duplicate definition of git_http_auth_dummy.

JohannesWilde · JohannesWilde · commit c88163230629 · 2025-05-24T13:31:56.000+02:00
src\libgit2\transports\auth_negotiate.h redefines git_http_auth_negotiate as git_http_auth_dummy if GIT_AUTH_NEGOTIATE is not defined, which thus leads to the uncommented code actually being a redifintion of git_http_auth_dummy. The linker complained [Windows 11, MSVC 2022 64bit].
diff --git a/src/libgit2/transports/auth_sspi.c b/src/libgit2/transports/auth_sspi.c
@@ -324,12 +324,14 @@ static int sspi_init_context(
 	return 0;
 }
 
+#ifdef GIT_AUTH_NEGOTIATE
 int git_http_auth_negotiate(
 	git_http_auth_context **out,
 	const git_net_url *url)
 {
 	return sspi_init_context(out, GIT_HTTP_AUTH_NEGOTIATE, url);
 }
+#endif
 
 int git_http_auth_ntlm(
 	git_http_auth_context **out,

Original file line number	Diff line number	Diff line change
`@@ -324,12 +324,14 @@ static int sspi_init_context(`
`324`	`324`	`return 0;`
`325`	`325`	`}`
`326`	`326`
	`327`	`+#ifdef GIT_AUTH_NEGOTIATE`
`327`	`328`	`int git_http_auth_negotiate(`
`328`	`329`	`git_http_auth_context **out,`
`329`	`330`	`const git_net_url *url)`
`330`	`331`	`{`
`331`	`332`	`return sspi_init_context(out, GIT_HTTP_AUTH_NEGOTIATE, url);`
`332`	`333`	`}`
	`334`	`+#endif`
`333`	`335`
`334`	`336`	`int git_http_auth_ntlm(`
`335`	`337`	`git_http_auth_context **out,`