net: don't free wrapped transport on failure

ethomson · ethomson · commit ac399148d24e · 2023-08-30T21:41:05.000+01:00
diff --git a/src/libgit2/transports/smart.c b/src/libgit2/transports/smart.c
@@ -523,7 +523,6 @@ int git_transport_smart(git_transport **out, git_remote *owner, void *param)
 	    definition->callback(&t->wrapped, &t->parent, definition->param) < 0) {
 		git_vector_free(&t->refs);
 		git_vector_free(&t->heads);
-		t->wrapped->free(t->wrapped);
 		git__free(t);
 		return -1;
 	}

Original file line number	Diff line number	Diff line change
`@@ -523,7 +523,6 @@ int git_transport_smart(git_transport *out, git_remote owner, void *param)`
`523`	`523`	`definition->callback(&t->wrapped, &t->parent, definition->param) < 0) {`
`524`	`524`	`git_vector_free(&t->refs);`
`525`	`525`	`git_vector_free(&t->heads);`
`526`		`- t->wrapped->free(t->wrapped);`
`527`	`526`	`git__free(t);`
`528`	`527`	`return -1;`
`529`	`528`	`}`