repo: dump backends on oid type change

ethomson · ethomson · commit 83a5b182c1d1 · 2023-01-24T12:24:41.000Z
diff --git a/src/libgit2/repository.c b/src/libgit2/repository.c
@@ -1032,7 +1032,8 @@ int git_repository_open_ext(
 			goto cleanup;
 	}
 
-	if ((error = load_objectformat(repo, config)) < 0)
+	if (version > 0 &&
+	    (error = load_objectformat(repo, config)) < 0)
 		goto cleanup;
 
 	/*
@@ -1670,6 +1671,12 @@ int git_repository__set_objectformat(
 	if (oid_type == GIT_OID_DEFAULT)
 		return 0;
 
+	if (!git_repository_is_empty(repo) && repo->oid_type != oid_type) {
+		git_error_set(GIT_ERROR_REPOSITORY,
+			"cannot change object id type of existing repository");
+		return -1;
+	}
+
 	if (git_repository_config__weakptr(&cfg, repo) < 0)
 		return -1;
 
@@ -1679,7 +1686,18 @@ int git_repository__set_objectformat(
 			git_oid_type_name(oid_type)) < 0)
 		return -1;
 
-	repo->oid_type = oid_type;
+	/*
+	 * During repo init, we may create some backends with the
+	 * default oid type. Clear them so that we create them with
+	 * the proper oid type.
+	 */
+	if (repo->oid_type != oid_type) {
+		set_index(repo, NULL);
+		set_odb(repo, NULL);
+		set_refdb(repo, NULL);
+
+		repo->oid_type = oid_type;
+	}
 
 	return 0;
 }
