Deprecate git_off_t

ethomson · ethomson · commit 5d18fc549eaa · 2019-06-23T19:38:07.000+01:00
We used `git_off_t` in places that called for an unsigned type, causing
difficulty for end users.  Deprecate it, replacing it with
`git_object_size_t`.
diff --git a/include/git2/deprecated.h b/include/git2/deprecated.h
@@ -287,6 +287,8 @@ GIT_EXTERN(int) git_index_add_frombuffer(
 #define GIT_OBJ_OFS_DELTA GIT_OBJECT_OFS_DELTA
 #define GIT_OBJ_REF_DELTA GIT_OBJECT_REF_DELTA
 
+typedef git_object_size_t git_off_t;
+
 GIT_EXTERN(size_t) git_object__size(git_object_t type);
 
 /**@}*/
diff --git a/include/git2/types.h b/include/git2/types.h
@@ -36,31 +36,15 @@ GIT_BEGIN_DECL
 #include <stdint.h>
 #endif
 
+/** Time in seconds from the Unix epoch */
 #if defined(_MSC_VER)
-
-typedef __int64 git_off_t;
 typedef __time64_t git_time_t;
-
 #elif defined(__MINGW32__)
-
-typedef off64_t git_off_t;
 typedef __time64_t git_time_t;
-
 #elif defined(__HAIKU__)
-
-typedef __haiku_std_int64 git_off_t;
 typedef __haiku_std_int64 git_time_t;
-
-#else /* POSIX */
-
-/*
- * Note: Can't use off_t since if a client program includes <sys/types.h>
- * before us (directly or indirectly), they'll get 32 bit off_t in their client
- * app, even though /we/ define _FILE_OFFSET_BITS=64.
- */
-typedef int64_t git_off_t;
-typedef int64_t git_time_t; /**< time in seconds from epoch */
-
+#else
+typedef int64_t git_time_t;
 #endif
 
 /** The maximum size of an object */
