Removing redundant call to find start line.

Tim · Tim · commit 3b6288af7ecf · 2023-05-31T15:29:01.000+01:00
diff --git a/src/libgit2/blame.c b/src/libgit2/blame.c
@@ -117,15 +117,12 @@ static git_blame_hunk *dup_hunk(git_blame_hunk *hunk, git_blame *blame)
 static void shift_hunks_by(git_vector *v, size_t start_line, int shift_by)
 {
 	size_t i;
-
-	if (!git_vector_bsearch2(&i, v, hunk_byfinalline_search_cmp, &start_line)) {
-		for (i = 0; i < v->length; i++) {
-			git_blame_hunk *hunk = (git_blame_hunk*)v->contents[i];
-			if(hunk->final_start_line_number < start_line){
-			        continue;
-			}
-			hunk->final_start_line_number += shift_by;
+	for (i = 0; i < v->length; i++) {
+		git_blame_hunk *hunk = (git_blame_hunk*)v->contents[i];
+		if(hunk->final_start_line_number < start_line){
+		        continue;
 		}
+		hunk->final_start_line_number += shift_by;
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -117,15 +117,12 @@ static git_blame_hunk dup_hunk(git_blame_hunk hunk, git_blame *blame)`
`117`	`117`	`static void shift_hunks_by(git_vector *v, size_t start_line, int shift_by)`
`118`	`118`	`{`
`119`	`119`	`size_t i;`
`120`		`-`
`121`		`- if (!git_vector_bsearch2(&i, v, hunk_byfinalline_search_cmp, &start_line)) {`
`122`		`- for (i = 0; i < v->length; i++) {`
`123`		`- git_blame_hunk hunk = (git_blame_hunk)v->contents[i];`
`124`		`- if(hunk->final_start_line_number < start_line){`
`125`		`- continue;`
`126`		`- }`
`127`		`- hunk->final_start_line_number += shift_by;`
	`120`	`+ for (i = 0; i < v->length; i++) {`
	`121`	`+ git_blame_hunk hunk = (git_blame_hunk)v->contents[i];`
	`122`	`+ if(hunk->final_start_line_number < start_line){`
	`123`	`+ continue;`
`128`	`124`	`}`
	`125`	`+ hunk->final_start_line_number += shift_by;`
`129`	`126`	`}`
`130`	`127`	`}`
`131`	`128`