added V8_CFLAGS, V8_CXXFLAGS, V8_LDFLAGS

jsteemann · jsteemann · commit 534a31f211b4 · 2016-03-17T16:44:37.000+01:00
diff --git a/3rdParty/V8/CMakeLists.txt b/3rdParty/V8/CMakeLists.txt
@@ -119,7 +119,7 @@ if (${CMAKE_GENERATOR} MATCHES "Ninja")
   # Gyp wants to use its own clang if we don't set this:
   list(APPEND V8_GYP_ARGS
     -Dclang=0)
-#    -Dv8_use_snapshot=true
+
   list(APPEND V8_GYP_ARGS
     -I${V8_DIR}/build/standalone.gypi
     --depth=.
@@ -131,6 +131,7 @@ if (${CMAKE_GENERATOR} MATCHES "Ninja")
   )
 
   set(NINJA_BUILD_DIR "${V8_TARGET_DIR}/${NINJA_TARGET}")
+
   ExternalProject_Add(v8_build
     SOURCE_DIR
       "${V8_DIR}"
@@ -323,6 +324,10 @@ else ()
 
   option(USE_DEBUG_V8 "compile V8 in DEBUG mode" OFF)
 
+  set(V8_CFLAGS   "")
+  set(V8_CXXFLAGS "")
+  set(V8_LDFLAGS "")
+
   if (USE_DEBUG_V8)
     set(V8_TARGET_ARCH "${V8_PROC_ARCH}.debug")
   else ()
@@ -361,19 +366,23 @@ else ()
     -Dwerror=
   )
 
+  if (APPLE AND CMAKE_COMPILER_IS_CLANG)
+    set(V8_CXXFLAGS "${V8_CXXFLAGS} -stdlib=libc++")
+    set(V8_LDFLAGS  "${V8_LDFLAGS} -stdlib=libc++")
+  endif ()
+
   set(V8_COMPILE_ARGS
     -C ${V8_TARGET_DIR}
     -f Makefile.${V8_TARGET_ARCH}
     BUILDTYPE=Release
     builddir=${V8_TARGET_DIR}/${V8_TARGET_ARCH}
     CC=${CMAKE_C_COMPILER}
     CXX=${CMAKE_CXX_COMPILER}
+    CFLAGS=${V8_CFLAGS}
+    CXXFLAGS=${V8_CXXFLAGS}
+    LDFLAGS=${V8_LDFLAGS}
   )
 
-  if (APPLE AND CMAKE_COMPILER_IS_CLANG)
-    list(APPEND V8_COMPILE_ARGS CXXFLAGS=-stdlib=libc++ LDFLAGS=-stdlib=libc++)
-  endif ()
-
   list(APPEND V8_COMPILE_ARGS icui18n icuuc icudata)
   list(APPEND V8_COMPILE_ARGS v8)
 
