8000 test(nextjs): Don't run Next.js integration tests for Node.js < 14 (#… · leothorp/sentry-javascript@c23715a · GitHub
[go: up one dir, main page]
Skip to content

Commit c23715a

Browse files
lforstlforst
authored
test(nextjs): Don't run Next.js integration tests for Node.js < 14 (getsentry#10547)
1 parent b1b704f commit c23715a

File tree

2 files changed

+3
-15
lines changed

2 files changed

+3
-15
lines changed

‎.github/workflows/build.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -585,7 +585,7 @@ jobs:
585585
strategy:
586586
fail-fast: false
587587
matrix:
588-
node: [10, 12, 14, 16, 18, 20, 21]
588+
node: [14, 16, 18, 20, 21]
589589
steps:
590590
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
591591
uses: actions/checkout@v4
@@ -612,12 +612,12 @@ jobs:
612612
path: ${{ steps.npm-cache-dir.outputs.dir }}
613613
key: ${{ runner.os }}-Playwright-${{steps.playwright-version.outputs.version}}
614614
- name: Install Playwright browser if not cached
615-
if: steps.playwright-cache.outputs.cache-hit != 'true' && matrix.node >= 14
615+
if: steps.playwright-cache.outputs.cache-hit != 'true'
616616
run: npx playwright install --with-deps
617617
env:
618618
PLAYWRIGHT_BROWSERS_PATH: ${{steps.npm-cache-dir.outputs.dir}}
619619
- name: Install OS dependencies of Playwright if cache hit
620-
if: steps.playwright-cache.outputs.cache-hit == 'true' && matrix.node >= 14
620+
if: steps.playwright-cache.outputs.cache-hit == 'true'
621621
run: npx playwright install-deps
622622
- name: Run tests
623623
env:

‎packages/nextjs/test/run-integration-tests.sh

-12
Original file line numberDiff line numberDiff line change
@@ -45,18 +45,6 @@ for NEXTJS_VERSION in 10 11 12 13; do
4545
export NODE_MAJOR=$NODE_MAJOR
4646
export USE_APPDIR=$USE_APPDIR
4747

48-
# Next 10 requires at least Node v10
49-
if [ "$NODE_MAJOR" -lt "10" ]; then
50-
echo "[nextjs] Next.js is not compatible with versions of Node older than v10. Current version $NODE_VERSION"
51-
exit 0
52-
fi
53-
54-
# Next.js v11 requires at least Node v12
55-
if [ "$NODE_MAJOR" -lt "12" ] && [ "$NEXTJS_VERSION" -ge "11" ]; then
56-
echo "[nextjs@$NEXTJS_VERSION] Not compatible with Node $NODE_MAJOR"
57-
exit 0
58-
fi
59-
6048
# Next.js v13 requires at least Node v16
6149
if [ "$NODE_MAJOR" -lt "16" ] && [ "$NEXTJS_VERSION" -ge "13" ]; then
6250
echo "[nextjs@$NEXTJS_VERSION] Not compatible with Node $NODE_MAJOR"

0 commit comments

Comments
 (0)
0