Fixes NRE issues found by Covertity in ObjectDatabase.cs

J Wyman · J Wyman · commit fba0a7352d79 · 2015-06-08T15:22:41.000-07:00
diff --git a/LibGit2Sharp/ObjectDatabase.cs b/LibGit2Sharp/ObjectDatabase.cs
@@ -365,7 +365,9 @@ public virtual Commit CreateCommit(Signature author, Signature committer, string
 
             ObjectId commitId = Proxy.git_commit_create(repo.Handle, null, author, committer, message, tree, parentIds);
 
-            return repo.Lookup<Commit>(commitId);
+            Commit commit = repo.Lookup<Commit>(commitId);
+            Ensure.GitObjectIsNotNull(commit, commitId.Sha);
+            return commit;
         }
 
         /// <summary>
@@ -454,6 +456,8 @@ public virtual string ShortenObjectId(GitObject gitObject)
         /// <returns>A short string representation of the <see cref="ObjectId"/>.</returns>
         public virtual string ShortenObjectId(GitObject gitObject, int minLength)
         {
+            Ensure.ArgumentNotNull(gitObject, "gitObject");
+
             if (minLength <= 0 || minLength > ObjectId.HexSize)
             {
                 throw new ArgumentOutOfRangeException("minLength", minLength,
@@ -462,6 +466,11 @@ public virtual string ShortenObjectId(GitObject gitObject, int minLength)
 
             string shortSha = Proxy.git_object_short_id(repo.Handle, gitObject.Id);
 
+            if (shortSha == null)
+            {
+                throw new LibGit2SharpException("Unable to abbreviate SHA-1 value for GitObject " + gitObject.Id);
+            }
+
             if (minLength <= shortSha.Length)
             {
                 return shortSha;
